Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CYS] Show the default header and footers as the first option #45414

Merged
merged 2 commits into from Mar 8, 2024
Merged

[CYS] Show the default header and footers as the first option #45414

merged 2 commits into from Mar 8, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Mar 8, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #45383

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Click on Tools and run the Reset Customize Your Store and the Delete all products commands.
  4. Go to WooCommerce > Home, click on Start customizing and finish the flow.
  5. On the Assembler click on Choose your header and make sure the first header on the sidebar is the one selected.
  6. Go back and click on Choose your footer and make sure the first footer on the sidebar is the one selected.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Show the header and footer selected by default as the first option displayed on the list.

Comment

@albarin albarin force-pushed the 45383-selected-footer-header-first branch from 19339da to b0d7d68 Compare March 8, 2024 10:31
@albarin albarin marked this pull request as ready for review March 8, 2024 10:32
@albarin albarin requested review from gigitux and nefeline March 8, 2024 10:32
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 8, 2024
@woocommercebot woocommercebot requested a review from a team March 8, 2024 10:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited

Hi @gigitux, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

gigitux
gigitux approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited

Test Results Summary

Commit SHA: b0d7d68

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests325002603517m 15s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@albarin albarin merged commit 1c9620b into trunk Mar 8, 2024
37 checks passed
@albarin albarin deleted the 45383-selected-footer-header-first branch March 8, 2024 11:03
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 8, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 8, 2024
@Stojdza Stojdza added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 8, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
@albarin @Konamiman
[CYS] Show the default header and footers as the first option (#45414)
181e4c8 
* Show the default header and footers as the first option

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigitux gigitux gigitux approved these changes

@nefeline nefeline Awaiting requested review from nefeline

Assignees
No one assigned
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Milestone
8.8.0
Development

Successfully merging this pull request may close these issues.

[CYS on core] Make sure the header and footer selected by default are the first displayed on the list
3 participants
@albarin @gigitux @Stojdza