[CYS] Fix the Opt-in modal buttons and checkbox styles #45444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
force-pushed
the
fix-optin-modal-styles
branch
from
c466031
to
ba1bd57
Compare
|
Hi @gigitux, @nefeline, @verofasulo, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
github-actions
bot
added
the
plugin: woocommerce
Test Results SummaryCommit SHA: ba1bd57
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
nefeline
approved these changes
Mar 11, 2024
github-actions
bot
added
the
needs: analysis
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Fix the CYS Opt-in modal buttons and checkbox styles * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com>
alopezari
added
needs: external testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes the styles of the buttons and checkbox on the
Opt-inmodal for the fonts in the CYS flow.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Testerplugin if you don't have it enabled yet.customize-store./wp-admin/admin.php?page=wc-settings&tab=advanced§ion=woocommerce_comand disable the tracking.WooCommerce > Home.Choose fonts.opt in to usage tracking.Opt in to usage trackingmodal and that it looks like theAfterscreenshot below.Changelog entry
Significance
Type
Message
CYS - Fix the "Opt in to usage tracking" modal buttons and checkbox styles.
Comment