Add callback URL domain to auth screen #45445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
|
Hi @jorgeatorres, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: d902b52
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
barryhughes
reviewed
Mar 8, 2024
| <p> | ||
| <?php | ||
| /* Translators: %s Domain name from the callback URL. */ | ||
| printf( esc_html__( 'Credentials will be shared with the website %s.', 'woocommerce' ), '<strong>' . esc_html( wp_parse_url( $callback_url, PHP_URL_HOST ) ) . '</strong>' ); |
There was a problem hiding this comment.
A few small/optional things, just wanted to briefly discuss them:
- Should we drop the use of the word 'website'? It implies that accessing the domain should lead to a website of some kind, which may not always be the case.
- I guess this is implicit, but I'm wondering about structuring the sentence something like: "If you approve this request, credentials will be shared with <DOMAIN>. You should not proceed if you have any concerns about the validity of that domain." Overkill?
If we prefer to go ahead without these changes, totally fine: it works well, is already a nice enhancement and I'm hitting approve.
barryhughes
approved these changes
Mar 8, 2024
|
... +I guess we need a template version tag bump. |
github-actions
bot
added
the
needs: analysis
alopezari
added
needs: external testing
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* add callback URL domain to auth screen * add changelog file * bump template version * tweak wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Add callback URL domain to auth screen:
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
wp-env starthttp://localhost:8888/wc-auth/v1/authorize?app_name=Example+App&scope=read_write&user_id=1&return_url=https%3A%2F%2Fwoo.com%2F&callback_url=https%3A%2F%2Fexample.comand make sure it looks similar to the screenshot aboveChangelog entry
Significance
Type
Message
Comment