Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for Merchant Checkout Block flow #45449

Merged
merged 1 commit into from Mar 13, 2024

Conversation

veljkho
Copy link
Contributor

@veljkho veljkho commented Mar 8, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes # 638 and 641
This is half the milestone. I will make another PR to cover the rest 2 flows.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Checkout this locally
  2. Run: pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/create-checkout-block.spec.js
  3. Make sure it is passing

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@veljkho veljkho self-assigned this Mar 8, 2024
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 8, 2024
@veljkho veljkho changed the title Add test for merchant create checkout block Add E2E test for Merchant Checkout Block flow Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Test Results Summary

Commit SHA: b7d8c4d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests338001403528m 9s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@veljkho veljkho force-pushed the e2e/add/merchant-checkout-block branch from fcb4a66 to b7d8c4d Compare March 8, 2024 19:59
@veljkho veljkho requested review from a team March 8, 2024 20:00
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Hi , @woocommerce/solaris, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@adimoldovan adimoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well. Thanks @veljkho!

@adimoldovan adimoldovan merged commit 60aa614 into trunk Mar 13, 2024
34 checks passed
@adimoldovan adimoldovan deleted the e2e/add/merchant-checkout-block branch March 13, 2024 12:28
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 13, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 13, 2024
@alopezari alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants