New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the "Design your own" banner when editing a theme which is not TT4 #45481
Conversation
Test Results SummaryCommit SHA: 6fa3e81
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
559455b
to
57ffdda
Compare
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work here @albarin !
I can confirm everything is working as expected, the only oddity observed was this one:
Screen.Recording.2024-03-12.at.13.39.41.mov
There's a slight delay in switching the banner whenever the current active theme is an already customized version of TT4: do you think its worth fixing this on this PR or on a separate one?
@nefeline thanks for the catch, I've changed the fetching of the current theme to get it from context, to avoid that flickering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Confirmed things are working as expected now.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR adds the "switch theme warning modal" to the
Edit your custom theme
Intro page. The modal will only show when the active theme is NOT Twenty Twenty Four.Closes #44725
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Tester
plugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.Tools
and run theReset Customize Your Store
and theDelete all products
commands.wp-admin/admin.php?page=wc-admin&path=/customize-store
.Design your own
banner.Start designing
button.Cancel
closes the modal.Design a new theme
goes through the flow to the assembler.Changelog entry
Significance
Type
Message
CYS - Show the "Design your own" banner when editing a different theme than TT4 in the CYS flow.
Comment