Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the "Design your own" banner when editing a theme which is not TT4 #45481

Merged
merged 5 commits into from Mar 13, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Mar 11, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds the "switch theme warning modal" to the Edit your custom theme Intro page. The modal will only show when the active theme is NOT Twenty Twenty Four.

Closes #44725

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Click on Tools and run the Reset Customize Your Store and the Delete all products commands.
  4. Enable the TT4 theme.
  5. Switch to another block theme.
  6. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  7. Make sure you see the Design your own banner.
  8. Click on the Start designing button.
  9. Make sure you see this modal.
Screenshot 2024-03-08 at 15 26 45
  1. Check that clicking Cancel closes the modal.
  2. Check that clicking on Design a new theme goes through the flow to the assembler.
  3. Make sure the theme is switched to TT4.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Show the "Design your own" banner when editing a different theme than TT4 in the CYS flow.

Comment

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Test Results Summary

Commit SHA: 6fa3e81

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 39s
E2E Tests319003203517m 36s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@albarin albarin force-pushed the 44725-add-customize-button-modal-2 branch from 559455b to 57ffdda Compare March 11, 2024 14:37
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 11, 2024
@albarin albarin marked this pull request as ready for review March 11, 2024 14:39
Copy link
Contributor

github-actions bot commented Mar 11, 2024

Hi @gigitux, @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@woocommercebot woocommercebot requested a review from a team March 11, 2024 14:39
Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here @albarin !

I can confirm everything is working as expected, the only oddity observed was this one:

Screen.Recording.2024-03-12.at.13.39.41.mov

There's a slight delay in switching the banner whenever the current active theme is an already customized version of TT4: do you think its worth fixing this on this PR or on a separate one?

@albarin
Copy link
Contributor Author

albarin commented Mar 12, 2024

@nefeline thanks for the catch, I've changed the fetching of the current theme to get it from context, to avoid that flickering.
Can you have another look? 🙏

@albarin albarin requested a review from nefeline March 12, 2024 14:10
Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Confirmed things are working as expected now.

@albarin albarin merged commit e8e2c5d into trunk Mar 13, 2024
30 checks passed
@albarin albarin deleted the 44725-add-customize-button-modal-2 branch March 13, 2024 13:55
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 13, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 13, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS - Core] Customize your store button doesn't work when the active theme isn't TT4
3 participants