Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'List price' and 'Sale price' fields from the General tab #45495

Merged
merged 3 commits into from Mar 18, 2024

Conversation

mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Mar 11, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #39644

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure feature New product editor is enabled under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
  2. Go to Products > Add new
  3. Under the General tab the Basic details section should no longer have the List price and the Sale price fields

Before
image

After
image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@mdperez86 mdperez86 added focus: new product ux revamped product management experience team: Mothra labels Mar 11, 2024
@mdperez86 mdperez86 requested a review from a team March 11, 2024 20:34
@mdperez86 mdperez86 self-assigned this Mar 11, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 11, 2024
Copy link
Contributor

github-actions bot commented Mar 11, 2024

Hi @octaedro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Test Results Summary

Commit SHA: 4eec0bc

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests650028703527m 37s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@github-actions github-actions bot added the focus: e2e tests Issues related to e2e tests label Mar 12, 2024
@mdperez86 mdperez86 force-pushed the add/39644 branch 2 times, most recently from bdf2752 to 9a8b081 Compare March 12, 2024 15:26
@octaedro octaedro requested review from octaedro and removed request for a team March 12, 2024 17:14
@mdperez86 mdperez86 force-pushed the add/39644 branch 3 times, most recently from d67d0f3 to 0a56815 Compare March 12, 2024 21:34
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mdperez86! LGTM! 🚀

@mdperez86 mdperez86 merged commit 979a3c7 into trunk Mar 18, 2024
33 checks passed
@mdperez86 mdperez86 deleted the add/39644 branch March 18, 2024 14:54
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 18, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 18, 2024
@octaedro octaedro mentioned this pull request Mar 18, 2024
11 tasks
@alvarothomas alvarothomas added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests focus: new product ux revamped product management experience needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove 'List price' and 'Sale price' fields from the General tab
3 participants