New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a filter woocommerce_admin_terms_metabox_datalimit
to change the data-limit value for the attributes term box
#45506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
label
Mar 12, 2024
lsinger
commented
Mar 12, 2024
plugins/woocommerce/includes/admin/meta-boxes/views/html-product-attribute-inner.php
Outdated
Show resolved
Hide resolved
lsinger
commented
Mar 12, 2024
Test Results SummaryCommit SHA: a433b05
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Add a new filter `woocommerce_admin_terms_metabox_datalimit` to change the value of data-limit. See #37548 for more context.
lsinger
force-pushed
the
add/woocommerce-terms-metabox-datalimit
branch
from
March 12, 2024 12:47
e5f9ae4
to
a433b05
Compare
lsinger
requested review from
nathanss,
a team and
coreymckrill
and removed request for
a team
March 12, 2024 12:52
Hi @jorgeatorres, @coreymckrill, @nathanss, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
nathanss
approved these changes
Mar 12, 2024
github-actions
bot
added
the
needs: analysis
Indicates if the PR requires a PR testing scrub session.
label
Mar 12, 2024
11 tasks
alopezari
added
needs: internal testing
Indicates if the PR requires further testing conducted by Solaris
status: analysis complete
Indicates if a PR has been analysed by Solaris
and removed
needs: analysis
Indicates if the PR requires a PR testing scrub session.
labels
Mar 12, 2024
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
…e data-limit value for the attributes term box (#45506) * Update html-product-attribute-inner.php Add a new filter `woocommerce_admin_terms_metabox_datalimit` to change the value of data-limit. See #37548 for more context. * Update html-product-attribute-inner.php * Creating a changelog file again * update @SInCE tag * tweak changelog file wording --------- Co-authored-by: Saif H. Hassan <67080558+Babylon1999@users.noreply.github.com>
nigeljamesstevenson
added
the
release: highlight
Issues that have a high user impact and need to be discussed/paid attention to.
label
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs: internal testing
Indicates if the PR requires further testing conducted by Solaris
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
release: highlight
Issues that have a high user impact and need to be discussed/paid attention to.
status: analysis complete
Indicates if a PR has been analysed by Solaris
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This is a copy of #41411. Based on the discussion I preferred to take the PR over to get the CI checks sorted. All props to @Babylon1999.
Closes #37548.
The current attribute term list in the product editor imposes a limitation of 50 terms creating inconvenience for merchants with attributes exceeding this limit. Consequently, they are unable to search for terms from the drop-down menu.
This proposed solution allows for a flexible adjustment of the term limit by introducing a filter,
woocommerce_admin_terms_metabox_datalimit
, which will allow to modify the data-limit variable. This approach eliminates the need to edit the plugin files directly, providing a more streamlined and customizable solution.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Testing instructions and PR description taken over from the original PR.
Changelog entry
Significance
Type
Message
Comment