Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source property to legacy editor #45515

Merged
merged 2 commits into from Mar 12, 2024

Conversation

octaedro
Copy link
Contributor

@octaedro octaedro commented Mar 12, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds a source property to the legacy editor Tracks event after publishing or updating a product.

Closes #39449.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. In a brand new JN site, enable the legacy product editor.
  2. Go to WooCommerce > Settings > Advanced > Woo.com and enable tracking.
  3. Go to Products > Add New
  4. Create a new product. Then, modify it and press Update.
  5. Go to WooCommerce > Status > Logs
  6. Select the tracks file and look for the events: wcadmin_product_add_publish and wcadmin_product_edit. They should send the prop source with the value product-legacy-editor.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 12, 2024
@octaedro octaedro self-assigned this Mar 12, 2024
@octaedro octaedro added focus: new product ux revamped product management experience team: Mothra labels Mar 12, 2024
@octaedro octaedro requested a review from a team March 12, 2024 13:56
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@octaedro octaedro marked this pull request as ready for review March 12, 2024 14:11
@octaedro
Copy link
Contributor Author

Hi @pmcpinto,

Just to confirm, this PR adds a source prop to the legacy editor after adding or updating a product. The value that will be used is: product-legacy-editor.

If you think that it should be different, please add a comment to this PR, and I'll rename it.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Test Results Summary

Commit SHA: 54337d6

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests760027503518m 52s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice job @octaedro

@octaedro octaedro merged commit 55ec9ec into trunk Mar 12, 2024
44 of 45 checks passed
@octaedro octaedro deleted the dev/39449_add_source_prop_to_legacy_editor branch March 12, 2024 16:40
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 12, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 12, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 12, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
* Add source property to legacy editor

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Product editor]: add Source property value to the add_publish event in the legacy editor.
3 participants