New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source property to legacy editor #45515
Conversation
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Hi @pmcpinto, Just to confirm, this PR adds a If you think that it should be different, please add a comment to this PR, and I'll rename it. |
Test Results SummaryCommit SHA: 54337d6
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice job @octaedro
* Add source property to legacy editor * Add changelog
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR adds a
source
property to the legacy editor Tracks event after publishing or updating a product.Closes #39449.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Update
.tracks
file and look for the events:wcadmin_product_add_publish
andwcadmin_product_edit
. They should send the propsource
with the valueproduct-legacy-editor
.Changelog entry
Significance
Type
Message
Comment