New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS] Fix the failed to load resource error in the CYS whenever the current active theme is not TT4 #45519
Conversation
Test Results SummaryCommit SHA: 1183042
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
plugins/woocommerce-admin/client/customize-store/design-without-ai/services.ts
Outdated
Show resolved
Hide resolved
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
2e1ef15
to
f58f129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work here @albarin, this was a very complex problem with a lot of nuances to it and you did an exceptional work on handling all possible scenarios of failure.
🚀
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #45479
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Tester
plugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.Tools
and run theReset Customize Your Store
and theDelete all products
commands.wp-admin/admin.php?page=wc-admin&path=%2Fcustomize-store
.Start designing
.Design a new theme
.wp-admin/themes.php
and make sure the active theme is TT4.Changelog entry
Significance
Type
Message
CYS - Fix the failed to load resource error in the CYS whenever the current active theme is not TT4
Comment