Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS] Fix the failed to load resource error in the CYS whenever the current active theme is not TT4 #45519

Merged
merged 11 commits into from Mar 15, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Mar 12, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #45479

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Click on Tools and run the Reset Customize Your Store and the Delete all products commands.
  4. Enable the TT1 theme.
  5. Go to wp-admin/admin.php?page=wc-admin&path=%2Fcustomize-store.
  6. Open the inspector.
  7. Click on Start designing.
  8. Make sure you see the following modal:
Screenshot 2024-03-13 at 16 52 20
  1. Click on Design a new theme.
  2. Check there's no 404 error in the inspector and the flow finishes and it loads the assembler (this is the error this PR is trying to fix, it should not happen anymore).
  3. Go to wp-admin/themes.php and make sure the active theme is TT4.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Fix the failed to load resource error in the CYS whenever the current active theme is not TT4

Comment

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Test Results Summary

Commit SHA: 1183042

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests258009403527m 25s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@albarin albarin changed the title Install and activate the TT4 before any other step on the loader [CYS] Install and activate the TT4 before any other step on the loader Mar 14, 2024
@albarin albarin changed the title [CYS] Install and activate the TT4 before any other step on the loader [CYS] Fix the failed to load resource error in the CYS whenever the current active theme is not TT4 Mar 14, 2024
@albarin albarin marked this pull request as ready for review March 14, 2024 09:43
@woocommercebot woocommercebot requested review from a team and samueljseay and removed request for a team March 14, 2024 09:43
Copy link
Contributor

github-actions bot commented Mar 14, 2024

Hi @gigitux, @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 14, 2024
@albarin albarin removed the request for review from samueljseay March 14, 2024 10:09
@albarin albarin requested a review from nefeline March 14, 2024 10:50
@albarin albarin requested a review from gigitux March 14, 2024 13:05
Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work here @albarin, this was a very complex problem with a lot of nuances to it and you did an exceptional work on handling all possible scenarios of failure.

🚀

@albarin albarin merged commit ad8f76b into trunk Mar 15, 2024
30 checks passed
@albarin albarin deleted the 45479-fix-404-error branch March 15, 2024 10:09
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 15, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS on Core] Fix the failed to load resource error in the CYS whenever the current active theme is not TT4
3 participants