New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable checkout menu when checkout block is default #45538
Disable checkout menu when checkout block is default #45538
Conversation
Hi @senadir, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
1 similar comment
Hi @senadir, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 25b41e2
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
3adb0fb
to
2551e1f
Compare
$handle = 'custom-notice'; | ||
wp_register_script( $handle, false, array( 'customize-controls' ), WC_VERSION, false ); | ||
wp_enqueue_script( $handle ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is needed to load the required dependencies. Without loading customize-controls
, the notice will not appear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a clever and working workaround, thank you for working on this Niels.
I'm glad to hear that, @senadir. And thanks for reviewing this PR. 🙌 |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #44120.
This PR adds the following changes:
Note
The acceptance criteria on #44120 mention "If the store has a block theme, the user should be redirected to the template". As the Customizer is not visible when using a block theme, I've skipped this acceptence criteria.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce » Settings » Advanced
and set the page with the Checkout block as the checkout page.Appearance » Customize » WooCommerce
.Checkout can be customized in the Editor with your active theme.
is visible.in the Editor
points to the editor page that contains the Checkout block.WooCommerce » Settings » Advanced
and set the page with the checkout shortcode as the checkout page.Apperance » Customize » WooCommerce
.Checkout can be customized in the Editor with your active theme.
is not visible.Appearance » Customize
is not visible.Changelog entry
Significance
Type
Message
Disable the checkout menu within Customizer when the checkout block is the default checkout page.
Comment