New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS on core] Introduce the Transitional page, i2 #45546
Conversation
Test Results SummaryCommit SHA: 23ef0bc
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
…cons and can be imported from there.
Hi @albarin, @danielwrobert, @gigitux, @tjcafferkey, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
@@ -130,73 +125,115 @@ export const Transitional = ( { | |||
window.open( homeUrl, '_blank' ); | |||
} } | |||
> | |||
{ __( 'Preview store', 'woocommerce' ) } | |||
{ __( 'View store', 'woocommerce' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some tests relying on this string that are failing, they are expecting the old Preview store
string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! Tests updated & also took the opportunity to add a new one :) : c103c11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!
Just left a comment about some failing tests, but pre-approving!
Submission Review Guidelines:
Changes proposed in this Pull Request:
Implement the new transitional page for the Customize Your Store flow, including the following updates:
Closes #45539
Closes #45511
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
wp-admin/edit.php?post_type=product
:Changelog entry
Significance
Type
Message
Introduce the new Transitional page to the customize your store.
Comment