Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS on core] Introduce the Transitional page, i2 #45546

Merged
merged 17 commits into from Mar 15, 2024

Conversation

nefeline
Copy link
Member

@nefeline nefeline commented Mar 13, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Implement the new transitional page for the Customize Your Store flow, including the following updates:

  • Updated subheading copy.
  • Updated copy for the "View store" button
  • Remove the store preview frame.
  • Updated the Actions section with a new "Add your products" item to create a better connection with product editing.
  • Added icons to each one of the sections
Before After
Screenshot 2024-03-14 at 22 31 46 Screenshot 2024-03-14 at 22 13 53
Before (mobile view) After (mobile view)
Screenshot 2024-03-14 at 22 32 01 Screenshot 2024-03-14 at 22 14 05

Closes #45539
Closes #45511

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure you have the WooCommerce Beta Tester plugin installed and activated
  2. Under Tools > WCA Test Helper > Features, make sure customize-store is enabled
  3. Under Tools > WCA Test Helper > Tools, click on Reset Customize Your Store and Delete all products
  4. Head over to WooCommerce > Home > Customize your store
  5. Click on "Start designing" and proceed to the Pattern Assembler
  6. Click on Done
  7. Make sure that you land on the following transitional page:
Screenshot 2024-03-14 at 22 13 53
  1. Make sure all links on the page work as expected. The new "Go to products" link should lead you to the products list wp-admin/edit.php?post_type=product:
Screenshot 2024-03-14 at 22 38 54
  1. Make sure the "Share feedback" and the "View store" buttons work as expected
  2. Make sure you can visualize the following while on mobile view:
Screenshot 2024-03-14 at 22 14 05

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Introduce the new Transitional page to the customize your store.

Comment

@nefeline nefeline linked an issue Mar 13, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Mar 13, 2024

Test Results Summary

Commit SHA: 23ef0bc

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests275007703526m 7s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@nefeline nefeline self-assigned this Mar 14, 2024
@nefeline nefeline added focus: customize-your-store Issues related to the Customize Your Store onboarding flow. type: enhancement The issue is a request for an enhancement. plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 14, 2024
@github-actions github-actions bot removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 14, 2024
@nefeline nefeline marked this pull request as ready for review March 14, 2024 21:44
@woocommercebot woocommercebot requested review from a team and tjcafferkey and removed request for a team March 14, 2024 21:44
Copy link
Contributor

github-actions bot commented Mar 14, 2024

Hi @albarin, @danielwrobert, @gigitux, @tjcafferkey,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 14, 2024
@@ -130,73 +125,115 @@ export const Transitional = ( {
window.open( homeUrl, '_blank' );
} }
>
{ __( 'Preview store', 'woocommerce' ) }
{ __( 'View store', 'woocommerce' ) }
Copy link
Contributor

@albarin albarin Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests relying on this string that are failing, they are expecting the old Preview store string.

Copy link
Member Author

@nefeline nefeline Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Tests updated & also took the opportunity to add a new one :) : c103c11

Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

Just left a comment about some failing tests, but pre-approving!

@nefeline nefeline merged commit 488bb62 into trunk Mar 15, 2024
31 checks passed
@nefeline nefeline deleted the 45539-cys-on-core-transitional-page-i2 branch March 15, 2024 11:27
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 15, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS on core] Transitional page, i2 [CYS on Core] Update the copy on the final transtional page
3 participants