Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Product Filter: Price (Beta) block - Disable block interactions within the editor #45602

Conversation

thealexandrelara
Copy link
Contributor

@thealexandrelara thealexandrelara commented Mar 14, 2024

Changes proposed in this Pull Request:

This PR disables the user interactions with the Product Filter: Price (Beta) block within the Editor.

Closes #45361 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Navigate to Single Product template (Appearance > Editor > Templates > Product Catalog template - or any archive template).
  2. Click on "Edit" to open the WordPress editor.
  3. In the editor, you should see a block inserter icon or an option to "Add Block". Click on it.
  4. Search for "Product Filter: Price (Beta)" in the block inserter or browse the available blocks until you find them. Add it to your content.
  5. Make sure you cannot interact with the input fields or the price slider of the block within the Editor.

Before

CleanShot.2024-03-14.at.17.00.32.mp4

After

CleanShot.2024-03-14.at.16.20.36.mp4

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Prevent user interaction with the Product Filter: Price (Beta) block within the Editor.

Comment

@thealexandrelara thealexandrelara added type: bug The issue is a confirmed bug. team: Kirigami & Origami block-type: filter blocks Issues related to all of the filter blocks. labels Mar 14, 2024
@thealexandrelara thealexandrelara self-assigned this Mar 14, 2024
@woocommercebot woocommercebot requested review from a team and kmanijak and removed request for a team March 14, 2024 19:35
Copy link
Contributor

Hi @kmanijak,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Test Results Summary

Commit SHA: 53b1ff5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests2260012703536m 56s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@kmanijak kmanijak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 15, 2024
@thealexandrelara thealexandrelara merged commit 21f2a15 into trunk Mar 15, 2024
55 of 56 checks passed
@thealexandrelara thealexandrelara deleted the fix/45361-disable-product-filter-price-block-interactions-within-the-editor branch March 15, 2024 20:18
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 15, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 19, 2024
@thealexandrelara thealexandrelara changed the title Product Filter: Price (Beta) block - Disable block interactions within the editor [Experimental] Product Filter: Price (Beta) block - Disable block interactions within the editor Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-type: filter blocks Issues related to all of the filter blocks. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Filter: Price (Beta) - Invalid Price Range Selection
3 participants