Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Collection: add e2e tests with all product elements included #45623

Conversation

kmanijak
Copy link
Contributor

@kmanijak kmanijak commented Mar 15, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Some time ago a user raised this issue: #44225. There was a fatal error when certain product element were used on a homepage. This PR adds E2E test verifying all product elements are correctly rendered in:

  • post
  • product archive
  • blog home

Closes #45214

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. CI passes especially Blocks E2E Playwright tests

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@kmanijak kmanijak changed the title 45214 product collection add e2e tests with all product elements included Product Collection: add e2e tests with all product elements included Mar 15, 2024
Copy link
Contributor

github-actions bot commented Mar 15, 2024

Test Results Summary

Commit SHA: 778666d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests760027703536m 29s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@kmanijak kmanijak added focus: e2e tests Issues related to e2e tests team: Kirigami & Origami block-type: product elements Issues related to Product Element blocks. block: product collection Issues related to the Product Collection block labels Mar 15, 2024
@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. and removed focus: e2e tests Issues related to e2e tests labels Mar 15, 2024
@kmanijak kmanijak marked this pull request as ready for review March 18, 2024 14:45
@woocommercebot woocommercebot requested review from a team and albarin and removed request for a team March 18, 2024 15:01
Copy link
Contributor

Hi @albarin,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
Copy link
Contributor

Hi @albarin,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kmanijak kmanijak merged commit 6cb52c0 into trunk Mar 19, 2024
61 checks passed
@kmanijak kmanijak deleted the 45214-product-collection-add-e2e-tests-with-all-product-elements-included branch March 19, 2024 07:59
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 19, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 19, 2024
@alvarothomas alvarothomas added focus: e2e tests Issues related to e2e tests status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: product collection Issues related to the Product Collection block block-type: product elements Issues related to Product Element blocks. focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Collection: add E2E tests with all Product Elements included
3 participants