Blocks E2E: Fix guest user handling in checkout tests #45624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nielslange, @gigitux, @kmanijak, @woocommerce/rubik, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
WunderBart
force-pushed
the
fix/e2e-logged-out-checkout
branch
from
3f063e3
to
f206943
Compare
Test Results SummaryCommit SHA: 692df11
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
11 tasks
WunderBart
force-pushed
the
fix/e2e-logged-out-checkout
branch
from
3a985b8
to
8249c2e
Compare
WunderBart
requested review from
a team,
nielslange and
kmanijak
and removed request for
a team
github-actions
bot
added
the
plugin: woocommerce
senadir
approved these changes
Mar 15, 2024
github-actions
bot
added
the
needs: analysis
alopezari
added
status: analysis complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Related: https://github.com/woocommerce/woocommerce/pull/44347/files#r1526255938
Fix flaky tests where the admin is logged out instead of using the guest storage state. Logging out via UI affects other tests as the user stays logged out.
Example error that should no longer happen:
How to test the changes in this Pull Request:
All affected tests should pass.