New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS on Core] Align the badge component in the themes intro screen #45626
Conversation
3efd395
to
70c0595
Compare
Hi @gigitux, @nefeline, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: c477c99
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I activated 4 different admin themes (Default, Ocean, Ectoplasm, and Sunrise) and the badge updates with each one, as expected.
Nice work!
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #45282
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce Beta Tester
plugin is installed and activated (available on this monorepo)./wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.WooCommerce > Home
and click onStart customizing
.wp-admin/profile.php
and change the colorAdmin Color Scheme
to another color and check the badge colors update accordingly.Changelog entry
Significance
Type
Message
CYS - Use the admin theme color to style the active theme badge component in the Intro page.
Comment