Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS on Core] Align the badge component in the themes intro screen #45626

Merged
merged 3 commits into from Mar 18, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Mar 15, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #45282

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Go to WooCommerce > Home and click on Start customizing.
  4. Check the active theme badge colors match with the active admin theme.
  5. Go to wp-admin/profile.php and change the color Admin Color Scheme to another color and check the badge colors update accordingly.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Use the admin theme color to style the active theme badge component in the Intro page.

Comment

@albarin albarin force-pushed the 45282-fix-active-badge-color branch from 3efd395 to 70c0595 Compare March 15, 2024 12:46
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 15, 2024
@albarin albarin marked this pull request as ready for review March 15, 2024 12:49
@woocommercebot woocommercebot requested a review from a team March 15, 2024 12:49
Copy link
Contributor

github-actions bot commented Mar 15, 2024

Hi @gigitux, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Test Results Summary

Commit SHA: c477c99

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests650028803537m 32s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@danielwrobert danielwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I activated 4 different admin themes (Default, Ocean, Ectoplasm, and Sunrise) and the badge updates with each one, as expected.

Nice work!

@albarin albarin merged commit 5e8bf7d into trunk Mar 18, 2024
30 checks passed
@albarin albarin deleted the 45282-fix-active-badge-color branch March 18, 2024 08:17
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 18, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 18, 2024
@alvarothomas alvarothomas added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS on Core] Align the badge component in the themes intro screen
4 participants