Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e tests] Stabilize product quick delete test #45636

Merged
merged 4 commits into from Mar 20, 2024

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented Mar 15, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes: #45520

The can quick delete a product from product list test has been flaky lately. After hovering the product row Playwright starts scrolling (I don't understand why), disabling the quick commands menu.
I've added a search by product name in the navigation url, to ensure increase the chances of no scrolling, hopefully it will help.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Run locally with pnpm env:restart && pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/product-delete.spec.js

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@adimoldovan adimoldovan self-assigned this Mar 15, 2024
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 15, 2024
Copy link
Contributor

github-actions bot commented Mar 15, 2024

Test Results Summary

Commit SHA: 8a9545d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests307004603537m 23s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@adimoldovan adimoldovan marked this pull request as ready for review March 15, 2024 22:44
@woocommercebot woocommercebot requested a review from a team March 15, 2024 22:45
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@adimoldovan adimoldovan enabled auto-merge (squash) March 18, 2024 08:31
Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should do the trick.

@adimoldovan adimoldovan merged commit 13ac914 into trunk Mar 20, 2024
31 checks passed
@adimoldovan adimoldovan deleted the e2e/improve-product-quick-delete-test branch March 20, 2024 13:59
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 20, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky] merchant/product-delete.spec.js
3 participants