Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent warning if there was no post ID available in some product elements #45675

Merged
merged 4 commits into from Mar 20, 2024

Conversation

kmanijak
Copy link
Contributor

@kmanijak kmanijak commented Mar 18, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

If there was no results in product list block while some product elements were in use, they would throw warning:

  • Product Rating
  • Product SKU
  • Product Sale Badge
  • Product Stock Indicator

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to Product Catalog template
  2. Remove the content
  3. Add Filter by Price block
  4. Add Product Collection block
  5. Choose Product Catalog collection
  6. Inside Product Collection (in Product Template) add following blocks:
  • Product Rating
  • Product SKU
  • Product Sale Badge
  • Product Stock Indicator
image
  1. Save and go to frontend (/shop)
  2. Change the price filter so there's no results available, for example by choosing really close min and max value:
image
  1. Refresh the page
  2. Expected: There's no warnings in Query Monitor
Before After
image Screen Shot 2024-03-18 at 15 59 50 PM

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@kmanijak kmanijak added type: bug The issue is a confirmed bug. team: Kirigami & Origami block-type: product elements Issues related to Product Element blocks. labels Mar 18, 2024
@woocommercebot woocommercebot requested review from a team and thealexandrelara and removed request for a team March 18, 2024 15:31
Copy link
Contributor

Hi @thealexandrelara,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 18, 2024

Test Results Summary

Commit SHA: 6179a82

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests2520010503577m 50s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@thealexandrelara thealexandrelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is testing well! I can confirm that no warning is being displayed in the Query Monitor. ✅

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 19, 2024
@kmanijak kmanijak merged commit a6500aa into trunk Mar 20, 2024
59 checks passed
@kmanijak kmanijak deleted the fix/warnings-from-product-elements branch March 20, 2024 13:49
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 20, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 21, 2024
@thealexandrelara thealexandrelara changed the title Prevent warning if there was no post ID available in some product elements [Experimental] Prevent warning if there was no post ID available in some product elements Mar 21, 2024
@kmanijak kmanijak changed the title [Experimental] Prevent warning if there was no post ID available in some product elements Prevent warning if there was no post ID available in some product elements Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-type: product elements Issues related to Product Element blocks. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants