Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS on Core] Ensure the "Didn’t find a theme you like" text is displayed exclusively at the bottom of the themes card #45706

Merged

Conversation

nefeline
Copy link
Member

Submission Review Guidelines:

Changes proposed in this Pull Request:

Ensure the "Didn’t find a theme you like" text and the "Design your own" banner are displayed exclusively at the bottom of the themes tab on WooCommerce > Extensions.

Closes #45705

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Head over to WooCommerce > Extensions > Themes wp-admin/admin.php?page=wc-admin&tab=themes&path=%2Fextensions
  2. Ensure you see the "design your own" banner and the Didn’t find a theme you like? Browse the WordPress.org theme directory to discover more. text at the bottom of the page:
Screenshot 2024-03-19 at 12 59 02 Screenshot 2024-03-19 at 12 59 25
  1. Head over to WooCommerce > Extensions > Discover: make sure you don't see the afore mentioned banner and text
  2. Head over to WooCommerce > Extensions > Browse: make sure you don't see the afore mentioned banner and text
  3. Head over to WooCommerce > Extensions > My subscriptions: make sure you don't see the afore mentioned banner and text

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Ensure the "Didn’t find a theme you like" text and the "Design your own" banner are displayed exclusively at the bottom of the themes tab on WooCommerce > Extensions.

Comment

@nefeline nefeline self-assigned this Mar 19, 2024
@nefeline nefeline added type: bug The issue is a confirmed bug. plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Mar 19, 2024
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@woocommercebot woocommercebot requested a review from a team March 19, 2024 12:39
Copy link
Contributor

github-actions bot commented Mar 19, 2024

Hi @gigitux, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@nefeline
Copy link
Member Author

Closing and re-opening this PR to attempt to kick some jobs that are stuck at the queued stage

@nefeline nefeline closed this Mar 19, 2024
@nefeline nefeline reopened this Mar 19, 2024
@nefeline nefeline enabled auto-merge (squash) March 19, 2024 14:57
@nefeline nefeline disabled auto-merge March 19, 2024 15:49
Copy link
Contributor

Test Results Summary

Commit SHA: 73fce23

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 40s
E2E Tests343001403579m 24s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@nefeline nefeline merged commit 61236da into trunk Mar 19, 2024
43 of 68 checks passed
@nefeline nefeline deleted the fix/themes-card-footer-copy-being-displayed-on-discover-card branch March 19, 2024 16:57
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 19, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 19, 2024
@alvarothomas alvarothomas added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris type: bug The issue is a confirmed bug.
Projects
None yet
3 participants