Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS] Transitional page: fix margins and make the 3rd question not required #45709

Merged
merged 3 commits into from Mar 20, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Mar 19, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR updates the margins in the transitional page and make the third question of the feedback for not required.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Go to WooCommerce > Home, click on Start customizing.
  4. In the assembler click on Done to go to the transitional page.
  5. Make sure the margin between the What's next? title and the colums and between the columns is 40px.
Screenshot 2024-03-19 at 13 59 13
  1. Click on Share feedback and make sure the Did you find anything confusing, irrelevant, or not useful? question is not mandatory.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Transitional page: fix margins and make the 3rd question not required.

Comment

@albarin albarin marked this pull request as ready for review March 19, 2024 13:07
@albarin albarin force-pushed the cys-transitional-design-tweaks branch from e96df0b to f67799a Compare March 19, 2024 13:32
@woocommercebot woocommercebot requested a review from a team March 19, 2024 13:33
Copy link
Contributor

github-actions bot commented Mar 19, 2024

Hi @gigitux, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Test Results Summary

Commit SHA: a63db20

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests770027903567m 2s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 20, 2024
@albarin albarin merged commit 7b22412 into trunk Mar 20, 2024
29 of 30 checks passed
@albarin albarin deleted the cys-transitional-design-tweaks branch March 20, 2024 08:46
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 20, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants