Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e tests] Improve test stability by using a stricter locator when checking product variation #45710

Merged
merged 1 commit into from Mar 20, 2024

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented Mar 19, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

can create a variation option and publish the product sometimes fails because the first element matching the created size ('Small') can be hidden and the test expects it to be visible. Example.
Updating the assertion to check that the variation input field contains the expected text would hopefully fix the issue.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/products/block-editor/create-variable-product-block-editor.spec.js

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@adimoldovan adimoldovan self-assigned this Mar 19, 2024
@adimoldovan adimoldovan marked this pull request as ready for review March 19, 2024 14:05
@woocommercebot woocommercebot requested a review from a team March 19, 2024 14:33
Copy link
Contributor

github-actions bot commented Mar 19, 2024

Hi @octaedro, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Test Results Summary

Commit SHA: 86ccd5a

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests00035703570m 0s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@adimoldovan adimoldovan enabled auto-merge (squash) March 20, 2024 13:08
Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. @octaedro Could you review to confirm that these changes still test the critical flow here?

Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adimoldovan for improving that test! LGTM! 🚀

@adimoldovan adimoldovan merged commit 207cccd into trunk Mar 20, 2024
37 of 39 checks passed
@adimoldovan adimoldovan deleted the e2e/fix/flaky-create-variable-product-test branch March 20, 2024 19:21
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 20, 2024
@alopezari alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 21, 2024
@adimoldovan adimoldovan mentioned this pull request Mar 22, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants