Prevent possible type error during WC_Install::create_options()

[jorgeatorres]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

This adds a type cast so that $settings_page->get_sections() always returns an array, which prevents a possible fatal error during install in cases where some code might be misusing the woocommerce_get_sections_<id> filter.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Add a snippet with the following code to your site:

   <?php
   add_filter( 'woocommerce_get_sections_general', '__return_null' );

2. We're going to "fake" an update in this conditions:

   wp option update woocommerce_version 8.7.9 &&  wp transient delete wc_installing
   

3. Open a page on your site to trigger the install routine.
4. No fatal error should appear.
5. Confirm WC has been updated by running wp option get woocommerce_version, which should output 8.8.0.
6. (Optional) Run 2-3 on trunk and verify that a fatal error does occur in that case.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Hi @lsinger,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Test Results Summary

Commit SHA: 572ee39

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	68	0	0	289	0	357	8m 16s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[lsinger]

Change looks good to me. Added a documentation block for the filter to appease the linter. Good to go once CI checks pass. 🚢