New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update product editor experiment name and enable pre-publish panel by default #45745
Conversation
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: b48883d
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
3930d45
to
de01af4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested...
control
- classic editor ✅treatment
- new product editor with pre-publish panel ✅- Manually enabling new product editor - pre-publish panel ✅
Thanks for taking care of this, @octaedro !
de01af4
to
c4e706e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed e2e code changes. Looks legit. Approving, assuming that e2e tests will pass. If they don't, then I'll give it another review if further changes are required!
Submission Review Guidelines:
Changes proposed in this Pull Request:
Updates the experiment name for the latest WC Release and enables the pre-publish panel by default.
Partially addresses #45736.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
woocommerce_product_creation_experience_prepublish_panel_202404_v1
and choose the variation you want to test./wp-admin/admin.php?page=wc-admin
and click on the second item to add a new product.Close the modal.
If you chose the "control" variation, you should see the classic product editor (which doesn't have a pre-publish panel).
If you selected the "treatment" variation, you should see the Publish dropdown and pre-publish panel after pressing
Publish
.Changelog entry
Significance
Type
Message
Comment