Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product editor experiment name and enable pre-publish panel by default #45745

Merged
merged 5 commits into from Mar 20, 2024

Conversation

octaedro
Copy link
Contributor

@octaedro octaedro commented Mar 20, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Updates the experiment name for the latest WC Release and enables the pre-publish panel by default.

Partially addresses #45736.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to the ExPlat experiment woocommerce_product_creation_experience_prepublish_panel_202404_v1 and choose the variation you want to test.
  2. When hovering over any Bookmarklet link of control or treatment variation, a popover should appear with instructions to try one of the variations.
  3. Be sure to save the suggested link to your browser bookmarks.
  4. Go to WooCommerce > Home and go through the OBW or skip.
  5. Go to /wp-admin/admin.php?page=wc-admin and click on the second item to add a new product.
  6. Click on the bookmark saved in step 3.
  7. After clicking the saved bookmark, a modal with this title should be shown ExPlat: Successful Assignment
    Close the modal.
  8. Click on one of those: physical, variable, digital, grouped, and external product type ( try to test at least a couple ).
    If you chose the "control" variation, you should see the classic product editor (which doesn't have a pre-publish panel).
    If you selected the "treatment" variation, you should see the Publish dropdown and pre-publish panel after pressing Publish.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 20, 2024
@octaedro octaedro self-assigned this Mar 20, 2024
@octaedro octaedro requested a review from a team March 20, 2024 12:59
@octaedro octaedro marked this pull request as ready for review March 20, 2024 13:00
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Test Results Summary

Commit SHA: b48883d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 39s
E2E Tests10035603570m 24s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@octaedro octaedro force-pushed the dev/45736_enable_prepublish_modal_feature branch from 3930d45 to de01af4 Compare March 20, 2024 15:59
Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested...

  • control - classic editor ✅
  • treatment - new product editor with pre-publish panel ✅
  • Manually enabling new product editor - pre-publish panel ✅

Thanks for taking care of this, @octaedro !

@octaedro octaedro force-pushed the dev/45736_enable_prepublish_modal_feature branch from de01af4 to c4e706e Compare March 20, 2024 18:34
@github-actions github-actions bot added the focus: e2e tests Issues related to e2e tests label Mar 20, 2024
Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed e2e code changes. Looks legit. Approving, assuming that e2e tests will pass. If they don't, then I'll give it another review if further changes are required!

@octaedro octaedro merged commit d565111 into trunk Mar 20, 2024
34 checks passed
@octaedro octaedro deleted the dev/45736_enable_prepublish_modal_feature branch March 20, 2024 20:14
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 20, 2024
@alopezari alopezari added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants