New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYS - Core: fix: not mark Customize your store step as completed when the user switches theme #45762
Conversation
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Hi @albarin, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
…oocommerce into fix/theme-mark-woo-express
Test Results SummaryCommit SHA: e0acffe
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
@gigitux, I hope you don't mind: I've pushed a change here to ensure this fix also applies to WooExpress. As a second thought from our previous discussion, I think it's worth having all users benefit from this fix, not just core. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Currently, the
Customize your store
step is marked when the user switches the theme. We disabled this beavhiour on Core.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Customize your store
step isn't marked.Customize your store
step is marked.Changelog entry
Significance
Type
Message
CYS - Core: fix: not mark
Customize your store
step as completed when the user switches themeComment