Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYS - Core: fix: not mark Customize your store step as completed when the user switches theme #45762

Merged
merged 7 commits into from Mar 20, 2024

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Mar 20, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Currently, the Customize your store step is marked when the user switches the theme. We disabled this beavhiour on Core.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Head over to WooCommerce > Home.
  2. Ensure that the Customize your store step isn't marked.
  3. Switch theme.
  4. Head over to WooCommerce > Home.
  5. Click on Customize your store.
  6. Click on "Start designing" and proceed to the Pattern Assembler.
  7. Clic on "Done".
  8. Head over to WooCommerce > Home.
  9. Ensure that the Customize your store step is marked.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Core: fix: not mark Customize your store step as completed when the user switches theme

Comment

@gigitux gigitux self-assigned this Mar 20, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 20, 2024
@gigitux gigitux added focus: customize-your-store Issues related to the Customize Your Store onboarding flow. type: bug The issue is a confirmed bug. and removed plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 20, 2024
@gigitux gigitux changed the title CYS - Core: fix: not mark step as completed CYS - Core: fix: not mark Customize your store step as completed when the user switches theme Mar 20, 2024
Copy link
Contributor

Hi @albarin, @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Hi @albarin,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 20, 2024
@gigitux gigitux enabled auto-merge (squash) March 20, 2024 16:35
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Test Results Summary

Commit SHA: e0acffe

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests00035703570m 0s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@gigitux gigitux merged commit 7f45f13 into trunk Mar 20, 2024
33 checks passed
@gigitux gigitux deleted the fix/theme-mark-woo-express branch March 20, 2024 22:47
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 20, 2024
@nefeline
Copy link
Member

@gigitux, I hope you don't mind: I've pushed a change here to ensure this fix also applies to WooExpress. As a second thought from our previous discussion, I think it's worth having all users benefit from this fix, not just core.

@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants