Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e tests] Disable the task list reminder bar in products list #45772

Merged
merged 1 commit into from Mar 21, 2024

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented Mar 20, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #45751

The task list reminder bar pops up in the products list, sometimes right after the hover action over a product that made the quick actions visible. This changes the layout enough for the quick action to be hidden again, breaking tests.
Disabling the bar in these tests by setting woocommerce_task_list_reminder_bar_hidden to yes should help with this.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

e2e tests in CI pass.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@adimoldovan adimoldovan self-assigned this Mar 20, 2024
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 20, 2024
Copy link
Contributor

Test Results Summary

Commit SHA: e5430f2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests3110046035710m 27s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@adimoldovan adimoldovan marked this pull request as ready for review March 21, 2024 07:19
@woocommercebot woocommercebot requested a review from a team March 21, 2024 07:19
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanej0 lanej0 merged commit d8453be into trunk Mar 21, 2024
36 checks passed
@lanej0 lanej0 deleted the e2e/fix/product-list-quick-actions branch March 21, 2024 17:20
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 21, 2024
@veljkho veljkho added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky] merchant/product-delete.spec.js
3 participants