Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concurrency group for pr label workflow #45793

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented Mar 21, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Updated the concurrency group for the PR labeller workflow to something unique to the PR. For pull_request_target trigger the github.ref value is the base branch, making the group name for PRs from the same base branch identical. The effect is that 'Label Pull Request Project' running on one PR could cancel the same workflow running for another PR.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Need two PRs for branches with same base branch.
  2. Update one branch so that 'Label Pull Request Project' starts.
  3. Update the second branch so that 'Label Pull Request Project' starts in parallel to the previous one.

The first workflow should not be cancelled.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the focus: monorepo infrastructure Issues and PRs related to monorepo tooling. label Mar 21, 2024
@adimoldovan adimoldovan self-assigned this Mar 21, 2024
@adimoldovan adimoldovan marked this pull request as ready for review March 21, 2024 13:01
Copy link
Contributor

github-actions bot commented Mar 21, 2024

Test Results Summary

Commit SHA: 64e440e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests319004903689m 4s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@woocommercebot woocommercebot requested a review from a team March 21, 2024 13:05
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rrennick rrennick merged commit e9777de into trunk Mar 22, 2024
21 checks passed
@rrennick rrennick deleted the ci/update-concurrency-group-for-pr-label branch March 22, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants