Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS] Update the Share feedback survey design #45802

Merged
merged 3 commits into from Mar 21, 2024
Merged

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Mar 21, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #45798

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  2. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  3. Go to WooCommerce > Home, click on Start customizing.
  4. Finish the flow and click on Done.
  5. On the transitional page click on the Share feedback button.
  6. Check the survey matches the design FlPl7fHaGv9mpu8Nfl0joH-fi-625_46162
Before After
Screenshot 2024-03-21 at 16 19 03 Screenshot 2024-03-21 at 16 16 48

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Update the "Share feedback" survey design

Comment

@albarin albarin marked this pull request as ready for review March 21, 2024 15:20
Copy link
Contributor

github-actions bot commented Mar 21, 2024

Hi @gigitux, @nefeline, @verofasulo, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@woocommercebot woocommercebot requested a review from a team March 21, 2024 15:20
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 21, 2024
Copy link
Contributor

github-actions bot commented Mar 21, 2024

Test Results Summary

Commit SHA: 9b7e978

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests00035703570m 0s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@albarin albarin merged commit 4eb9063 into trunk Mar 21, 2024
30 checks passed
@albarin albarin deleted the update-cys-survey-design branch March 21, 2024 17:30
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 21, 2024
@veljkho veljkho added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS] Update the Share feedback survey design
3 participants