Remove accidental count call within an is_array check

[louwie17]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Fixes: #45911

This is a fix that was introduced by this PR #43233, where a count call was accidentally added within an is_array call. Meaning that it would always render false.

This fixes an issue in the Analytics products page when filtering by a selected product, in which case the graph doesn't show up and it shows an error ( see issue ).

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Create a WooCommerce store with a couple variable products
2. Create an order with one of the variable products and complete it.
3. Make sure order actions finished under WooCommerce > Status > Scheduled Actions
4. Go to Analytics > Products
5. Select one of the variable products that you had an order with within the Show dropdown
6. There should be no errors and the graph should render correctly.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Hi @asumaran, @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Hi @asumaran, @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Test Results Summary

Commit SHA: b7c6b39

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	76	0	0	303	0	379	8m 19s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[asumaran]

I can confirm the bug is there and can see the error is gone after applying the changes from this PR.

Before	After

I must have forgot to test with variable products. Sorry about that.

LGTM! Thanks for fixing it @louwie17.