Fix: Suppress deprecated warning when applying a coupon on Cart in PHP > 8.0 #45981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
github-actions
bot
added
the
plugin: woocommerce
|
Hi @nielslange, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
wavvves
added
type: bug
Test Results SummaryCommit SHA: e3d2668
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
wavvves
deleted the
fix/45956-applying-coupons-in-generates-php-deprecated
branch
github-actions
bot
added
the
needs: analysis
|
Hi' i've submitted the related #45956, will this fix be applied to the final 8.8 release???(i'm seeing the fix added to 8.9 milestone, but the issue i've found affects the upcoming 8.8 right now) |
Hi @Danielspain22, we're still evaluating impact to determine the version of WC this will ship in. The PR will be updated once more information is available |
alopezari
added
needs: external testing
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
…P > 8.0 (#45981) * Fix deprecated warning when applying a coupon on Cart in PHP > 8.0 * Add changefile(s) from automation for the following project(s): woocommerce * Changed property type to protected --------- Co-authored-by: github-actions <github-actions@github.com>
This was referenced Mar 28, 2024
Stojdza
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Fix: Suppress deprecated warning when applying a coupon on Cart in PHP > 8.0 (#45981) * Fix deprecated warning when applying a coupon on Cart in PHP > 8.0 * Add changefile(s) from automation for the following project(s): woocommerce * Changed property type to protected --------- Co-authored-by: github-actions <github-actions@github.com> * Prep for cherry pick 45981 --------- Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: WooCommerce Bot <no-reply@woo.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
New changes on #43872 introduced a deprecated warning when attempting to run
strlenon a null string (billing_email in this case, which is not supplied in cart)This PR adds a new check to prevent that, and also adds the
string$error_messageproperty to classWC_Couponto prevent another warning on the same class.Closes #45956 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/tools.php?page=debug-log-managershould not contain deprecated warnings statingDeprecated: strlen(): Passing null to parameteror related to creation of a dynamic property callederror_messageChangelog entry
Significance
Type
Message
Comment
Fix: Suppress deprecated warning when applying a coupon on Cart in PHP > 8.0