Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styling bug with saved payment methods in Checkout block #46019

Merged
merged 2 commits into from Mar 29, 2024
Merged

Fix styling bug with saved payment methods in Checkout block #46019

merged 2 commits into from Mar 29, 2024

Conversation

opr
Copy link
Contributor

@opr opr commented Mar 27, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #45955 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable Stripe, or some other method that uses saved payment methods.
  2. As a logged-in user, add an item to your cart and check out using this payment method. Save the payment method to your account.
  3. Re-add an item and return to the checkout block.
  4. Ensure the saved payment method is rendering correctly when there is only one method.
image
  1. Repeat this again and check out with a different card (so that you can save it and have two saved methods).
  2. Re-add an item to the cart and return to the checkout.
  3. Ensure the saved payment methods display OK when there are more than one.
image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@opr opr added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 27, 2024
@opr opr self-assigned this Mar 27, 2024
@woocommercebot woocommercebot requested review from a team and nielslange and removed request for a team March 27, 2024 16:52
@opr opr requested a review from frosso March 27, 2024 16:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited

Hi @nielslange,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

nielslange
nielslange approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue, @opr. The change looks good. Let's ⛴️ it!

frosso
frosso approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@frosso frosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you! :shipit:

@opr opr merged commit dbf0938 into trunk Mar 29, 2024
55 checks passed
@opr opr deleted the fix/saved-payment-method-styling branch March 29, 2024 09:30
@github-actions github-actions bot added this to the 8.9.0 milestone Mar 29, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 29, 2024
@veljkho veljkho added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 29, 2024
moon0326 pushed a commit that referenced this pull request Mar 29, 2024
@opr @moon0326
Fix styling bug with saved payment methods in Checkout block (#46019)
1ea2813
moon0326 pushed a commit that referenced this pull request Mar 29, 2024
@opr @moon0326
Fix styling bug with saved payment methods in Checkout block (#46019)
7b12dd4
This was referenced Mar 29, 2024
Merged
Open
@Stojdza Stojdza modified the milestones: 8.9.0, 8.8.0 Apr 3, 2024
github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
@opr
Fix styling bug with saved payment methods in Checkout block (#46019)
aa597eb
This was referenced Apr 3, 2024
Merged
Merged
Stojdza pushed a commit that referenced this pull request Apr 3, 2024
@github-actions @opr
Cherry pick 46019 into release/8.8 (#46167)
86f5aba 
* Fix styling bug with saved payment methods in Checkout block (#46019)

* Prep for cherry pick 46019

---------

Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com>
Co-authored-by: WooCommerce Bot <no-reply@woo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frosso frosso frosso approved these changes

@nielslange nielslange nielslange approved these changes

Assignees

@opr opr

Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Milestone
8.8.0
Development

Successfully merging this pull request may close these issues.

Saved payment options UI regression in 8.6.1 > 8.7.0
5 participants
@opr @frosso @nielslange @Stojdza @veljkho