Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the $check_key_exists parameter from AssetDataRegistry and disallow duplicate data for all cases #46139

Merged
merged 19 commits into from
Apr 8, 2024
Merged

Deprecate the $check_key_exists parameter from AssetDataRegistry and disallow duplicate data for all cases #46139

merged 19 commits into from
Apr 8, 2024

Commits on Mar 28, 2024

  1. Ensures data is added to the registry just once.

    @nefeline
    nefeline committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7183dca View commit details
    Browse the repository at this point in the history

  2. ditch unnecessary param.

    @nefeline
    nefeline committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7228fde View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Deprecate the param for AssetDataRegistry

    @nefeline
    nefeline committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f6a0758 View commit details
    Browse the repository at this point in the history

  2. Remove the param for additional calls to AssetDataRegistry::add()

    @nefeline
    nefeline committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    48142ca View commit details
    Browse the repository at this point in the history

  3. Remove the param for additional call to AssetDataRegistry::add() on W… 

    …CAdminSharedSettings
    @nefeline
    nefeline committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    3f5847b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Trigger a PHP warning instead of throwing a fatal whenever the key be… 

    …ing registered is not a string and whenever attempting to override existing data.
    @nefeline
    nefeline committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    534082e View commit details
    Browse the repository at this point in the history

  2. Add changefile(s) from automation for the following project(s): wooco… 

    …mmerce
    github-actions committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    612c40a View commit details
    Browse the repository at this point in the history

  3. Resolve conflict & merge latest trunk

    @nefeline
    nefeline committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    6c673f3 View commit details
    Browse the repository at this point in the history

  4. Replace trigger_error with error_log to clear out lint errors.

    @nefeline
    nefeline committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1500045 View commit details
    Browse the repository at this point in the history

  5. Address lint for trigger_error

    @nefeline
    nefeline committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ab6a5ab View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Update the test_already_existing_key_on_adding_data test to expect a … 

    …warning instead of an exception
    @nefeline
    nefeline committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    809eefd View commit details
    Browse the repository at this point in the history

  2. Merge trunk and solve conflicts.

    @nefeline
    nefeline committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    787867e View commit details
    Browse the repository at this point in the history

  3. Update tests

    @nefeline
    nefeline committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c69c321 View commit details
    Browse the repository at this point in the history

  4. Update method from add_data to add.

    @nefeline
    nefeline committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    9fd2532 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Remove the throw InvalidArgumentException for the add and add_data me… 

    …thods.
    @nefeline
    nefeline committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    627b911 View commit details
    Browse the repository at this point in the history

  2. Remove the now unnecessary test_already_existing_key_on_adding_data t… 

    …est, considering we now return early whenever the key is duplicated, the code never reaches this stage via AssetDataRegistry:add
    @nefeline
    nefeline committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1fa885c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into 43404-cys-when-wp_debug-is-enabled-the-asse… 

    …mbler-is-not-loaded
    @nefeline
    nefeline committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    00ad85a View commit details
    Browse the repository at this point in the history

  4. Move the call to the exists method to within the add_data method.

    @nefeline
    nefeline committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1fcb81c View commit details
    Browse the repository at this point in the history

  5. Resolve conflict and merge latest trunk

    @nefeline
    nefeline committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    627b6ad View commit details
    Browse the repository at this point in the history