Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PaymentGatewaySuggestionsDataSourcePoller and disable deprecation logging #46163

Merged
merged 7 commits into from Apr 3, 2024
Merged

Fix PaymentGatewaySuggestionsDataSourcePoller and disable deprecation logging #46163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62f6da9
Temporarily disable deprecation logging and use old DataSourcePoller …
ilyasfoo Apr 3, 2024
2e11eba
Changelog
ilyasfoo Apr 3, 2024
5db2a0b
Update DataSourcePoller.php
ilyasfoo Apr 3, 2024
daace77
Change to comment for lint
ilyasfoo Apr 3, 2024
8c80525
Typo again
ilyasfoo Apr 3, 2024
ac7c246
Lint
ilyasfoo Apr 3, 2024
8c5c9ed
Better comment from @nigeljamesstevenson
ilyasfoo Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/fix-datasourcepoller-upgrade-issues
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: patch
Type: dev

Temporary disable DataSourcePoller class deprecation message
13 changes: 5 additions & 8 deletions plugins/woocommerce/src/Admin/DataSourcePoller.php
View file
Open in desktop
Expand Up @@ -16,14 +16,11 @@ abstract class DataSourcePoller extends RemoteSpecsDataSourcePoller {
* Log a deprecation to the error log.
*/
private static function log_deprecation() {
error_log( // phpcs:ignore
sprintf(
'%1$s is deprecated since version %2$s! Use %3$s instead.',
self::class,
'8.8.0',
'Automattic\WooCommerce\Admin\RemoteSpecs\DataSourcePoller'
)
);
/**
* Note: Deprecation messages have been temporarily disabled due to upgrade issues.
* For more details, see the discussion in the WooCommerce GitHub repository:
* https://github.com/woocommerce/woocommerce/pull/45892.
*/
}

/**
Expand Down
2 changes: 1 addition & 1 deletion ...rc/Admin/Features/PaymentGatewaySuggestions/PaymentGatewaySuggestionsDataSourcePoller.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Automattic\WooCommerce\Admin\Features\PaymentGatewaySuggestions;

use Automattic\WooCommerce\Admin\RemoteSpecs\DataSourcePoller;
use Automattic\WooCommerce\Admin\DataSourcePoller;

/**
* Specs data source poller class for payment gateway suggestions.
Expand Down