Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isSelectableByUser attribute to product templates #46394

Merged
merged 9 commits into from Apr 10, 2024

Conversation

nathanss
Copy link
Contributor

@nathanss nathanss commented Apr 9, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable the new product editor at /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
  2. Go to Products > Add
  3. Click on 'Change product type'
  4. Check the templates that are listed
  5. Install and enable the following plugin:
    test-product-template.zip
  6. Refresh the product page
  7. Check the templates again, you should NOT see a new template on the list, since the one added by the plugin has isSelectableByUser equal to false

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@nathanss nathanss self-assigned this Apr 9, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 9, 2024
Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well and code looks good. Just a minor comment about improving the changelog entry.

Significance: minor
Type: add

Use isSelectableByUser product template attribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to say why the attribute is being used.

Copy link
Contributor

Hi @mattsherman,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the changelog entry. Looks good!

@nathanss nathanss enabled auto-merge (squash) April 10, 2024 17:46
@nathanss nathanss merged commit 3fb7443 into trunk Apr 10, 2024
28 checks passed
@nathanss nathanss deleted the add/unselectable-product-templates branch April 10, 2024 17:57
@github-actions github-actions bot added this to the 8.9.0 milestone Apr 10, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Apr 10, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants