-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks E2E: Refactor configs and workflow #46409
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
22ad6f0
Merge all e2e configs
WunderBart e2263d3
Refactor tests workflow to address config changes
WunderBart 29ebb29
Move db import to page fixture setup
WunderBart 5b777e5
Improve wording
WunderBart 63c461c
Revert "Move db import to page fixture setup"
WunderBart 03d70c4
Tweak db import messages
WunderBart a2ff4e5
Fix artifacts path
WunderBart 38e32e5
Fix artifacts path again + bump action version
WunderBart d414289
Tweak job title
WunderBart 36aa547
Tweak some more titling
WunderBart 8b5bbbb
Fix artifacts name
WunderBart 277eae0
Use beforeEach hook for activating themes
WunderBart 752a585
Some more workflow tweaks
WunderBart ea98a46
Remove one more hook
WunderBart 21c074c
Fix failing guest shopper test
WunderBart e26065a
Add shard prefix to artifacts upload
WunderBart e39c672
Use actions/checkout@v4
WunderBart 9fd9300
Add artifacts merge step
WunderBart 33bbfb1
Remove comment
WunderBart 4466a5a
Add changelog entry
WunderBart dbe344d
Try generating html report
WunderBart 1c22e8c
Revert "Try generating html report"
WunderBart 60756b8
Streamline db error
WunderBart 3a60fac
Make exec reject on error
WunderBart 63165d4
Try 10 shards
WunderBart 1f8a5d3
Execute templates tests in parallel like before
WunderBart 77ebcd7
Revert "Execute templates tests in parallel like before"
WunderBart 3c7b30e
Remove side_effects suffix from test files
WunderBart d38f66c
Remove accidental pause
WunderBart 9179fdb
Fix linter errors
WunderBart f207d77
Restore the themed runners
WunderBart c3b894c
Reuse db snapshot to reduce global setup time
WunderBart 09c954e
Remove more unnecessary setup and teardown steps
WunderBart c41c431
Merge remote-tracking branch 'origin' into refactor/e2e-playwright-co…
WunderBart 4cb7525
Refactor out the isMacOS check
WunderBart 0492dae
Try generating HTML report take 2
WunderBart 03a54ea
Revert "Try generating HTML report take 2"
WunderBart f454021
Fix artifact merge when artifacts unavail. after rerun
WunderBart 53a94a6
tmp: print artifact id
WunderBart c00ff79
Revert "tmp: print artifact id"
WunderBart a5ba238
Merge remote-tracking branch 'origin' into refactor/e2e-playwright-co…
WunderBart 4898494
Fix mini cart test
WunderBart 522fc31
Handle perfect run
WunderBart b14ca43
Merge remote-tracking branch 'origin' into refactor/e2e-playwright-co…
WunderBart 894960d
Merge remote-tracking branch 'origin' into refactor/e2e-playwright-co…
WunderBart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
plugins/woocommerce-blocks/tests/e2e/block-theme-with-templates.setup.ts
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
plugins/woocommerce-blocks/tests/e2e/classic-theme.setup.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 0 additions & 28 deletions
28
plugins/woocommerce-blocks/tests/e2e/playwright.block-theme-with-templates.config.ts
This file was deleted.
Oops, something went wrong.
28 changes: 0 additions & 28 deletions
28
plugins/woocommerce-blocks/tests/e2e/playwright.classic-theme.config.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! That check was needed because the
cli
utility always resolved the promise, regardless of whether the executed script threw an error. I made it reject on an error in 3a60fac, so now we don't need these explicit output checks as they're handled inside the utility.