Can only be inserted once test excludes the mini-cart template button #46478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
ralucaStan
requested review from
a team and
nielslange
and removed request for
a team
ralucaStan
added
focus: cart
|
Hi @nielslange, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
ralucaStan
force-pushed
the
fix/e2e-mini-cart
branch
from
47afebb
to
00b270c
Compare
nielslange
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Thanks for working on this, @ralucaStan. I've noted a section that's unclear to me, although tests are passing both locally and in CI. Could you help clarify that particular part?
...e-blocks/tests/e2e/tests/mini-cart/mini-cart-block.merchant.block_theme.side_effects.spec.ts
Show resolved
Hide resolved
nielslange
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
With the open question addressed, let's ⛴️ this improvement, @ralucaStan.
|
I appreciate the thoughtful review @nielslange |
github-actions
bot
added
the
needs: analysis
alopezari
added
status: analysis complete
nielslange
pushed a commit
that referenced
this pull request
Apr 20, 2024
…#46478) * Can only be inserted once test excludes the mini-cart template button * Use function for testing disabled state * Account for blocks advertise and change selector
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
tests/e2e/tests/mini-cart/mini-cart-block.merchant.block_theme.side_effects.spec.ts > Can only be inserted once testexcludes the mini-cart template button.This test was failing for me locally because there is also a Mini-cart template button under Theme.
How to test the changes in this Pull Request:
Changelog entry
Significance
Type
Message
Comment