Fix duplicate product endpoint args for item schema #46551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
woocommercebot
requested review from
a team and
jorgeatorres
and removed request for
a team
|
Hi @jorgeatorres, @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
octaedro
changed the title
octaedro
added
team: Mothra
focus: new product ux
octaedro
commented
Apr 12, 2024
| @@ -99,10 +99,6 @@ public function duplicate_product( $request ) { | |||
| return new WP_Error( 'woocommerce_rest_product_invalid_id', __( 'Invalid product ID.', 'woocommerce' ), array( 'status' => 404 ) ); | |||
| } | |||
|
|
|||
| if ( 'simple' !== $product->get_type() ) { | |||
There was a problem hiding this comment.
I removed this because it's not necessary anymore.
github-actions
bot
added
the
needs: analysis
alopezari
added
needs: internal testing
nielslange
pushed a commit
that referenced
this pull request
Apr 20, 2024
* Fix endpoint args for item schema * Add tests * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes an error related to the duplicate product REST API endpoint. The method was working well but it did not duplicate the stock management option.
That was happening because we sent the wrong param to
get_endpoint_args_for_item_schema.This PR adds some unit tests and fixes the bug.
Product
typeandstatusare not editable.Closes #46535.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
DuplicateandDuplicate and modify. After pressing any of them, a prompt asking for aProduct IDto duplicate will be visible. After adding a product ID and pressing ok, it will send a request to/wp-json/wc/v3/products/[your-product-id]/duplicate.Consoletab.Duplicateand add the ID of the simple product to the prompt. If everything goes well you'll see the duplicated product printed in the console.(Copy)at the endDraft.Products > All Productsand find the duplicated product there.Products > All Products. Verify that the variations were duplicated correctly (the prices set in step 1 should match).Duplicate and modifyand add the ID of the simple product to the prompt. If everything goes well you'll see the duplicated product printed in the console. This option also sends a description of the product, so the duplicated product's description should say: "This is my description".Changelog entry
Significance
Type
Message
Comment