[Blocks] Migrate Attribute filter E2E tests to playwright #46591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That part is overriding the logged in user state and wipes out the nonce and rootUrl fields.
This reverts commit 987dc47.
This reverts commit c8d008c.
This reverts commit 2684273.
* Load local pickup enabled setting as bool not string * Add changelog * Remove unused import * Update plugins/woocommerce-blocks/assets/js/extensions/shipping-methods/pickup-location/utils.ts Co-authored-by: Niels Lange <info@nielslange.de> * Use strict equality test * try now * try now * add a new sql file * remove default.sql * fix welcome guide tour * fix E2E tests * Fix the template revert tests ...where the template is unreachable due to pagination. * Add changelog entry * improve logic to closeWelcomeGuideModal * fix cart checkout tests * improve flakiness * improve flakiness * fix flaky test * fix company field * fix E2E test * fix E2E tests --------- Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: Bart Kalisz <bartlomiej.kalisz@gmail.com>
add ESLint configuration
fix eslint error
… into try/attribute-filter-migration
…ce/woocommerce into try/attribute-filter-migration
github-actions
bot
added
plugin: woocommerce
gigitux
force-pushed
the
try/attribute-filter-migration
branch
from
c920c00
to
206d51c
Compare
* Fix ESLint errors * Add changefile(s) from automation for the following project(s): woocommerce-blocks --------- Co-authored-by: github-actions <github-actions@github.com>
… into try/attribute-filter-migration
gigitux
force-pushed
the
try/attribute-filter-migration
branch
from
dcaa9d2
to
5af79a5
Compare
alexflorisca
approved these changes
Apr 16, 2024
| await expect( products ).toHaveCount( 1 ); | ||
| } ); | ||
|
|
||
| test( 'should refresh the page only if the user click on button', async ( { |
There was a problem hiding this comment.
nitpick: change click to clicks
WunderBart
approved these changes
Apr 16, 2024
11 tasks
…ttribute-filter-migration
github-actions
bot
added
the
needs: analysis
samueljseay
pushed a commit
that referenced
this pull request
Apr 29, 2024
* try db reset in page teardown * move reset to setup step * Use wp db cli * Fix global setup That part is overriding the logged in user state and wipes out the nonce and rootUrl fields. * Try importing instead from a generated dump * Revert "Try importing instead from a generated dump" This reverts commit 987dc47. * Revert "Revert "Try importing instead from a generated dump"" This reverts commit c8d008c. * Don't bypass visitSiteEditor so that the Welcome Guide is closed * use createNewPost * Revert "Revert "Revert "Try importing instead from a generated dump""" This reverts commit 2684273. * [Blocks]: Fix E2E tests (#46344) * Load local pickup enabled setting as bool not string * Add changelog * Remove unused import * Update plugins/woocommerce-blocks/assets/js/extensions/shipping-methods/pickup-location/utils.ts Co-authored-by: Niels Lange <info@nielslange.de> * Use strict equality test * try now * try now * add a new sql file * remove default.sql * fix welcome guide tour * fix E2E tests * Fix the template revert tests ...where the template is unreachable due to pagination. * Add changelog entry * improve logic to closeWelcomeGuideModal * fix cart checkout tests * improve flakiness * improve flakiness * fix flaky test * fix company field * fix E2E test * fix E2E tests --------- Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: Bart Kalisz <bartlomiej.kalisz@gmail.com> * Replace beforeAll w/ beforeEach + remove all after* hooks * Fix broken hooks * Activate plugins via requestUtils API * [Blocks - E2E]: Add `playwright/no-hooks` ESlint rule (#46432) add ESLint configuration * Clean up console logs * Remove obsolete language setup steps * Remove more unnecessary setup steps * Remove even more obsolete setup steps * tmp: add the LYS fix * Try stabilizing the company field test * Use canvas param instead of manually entering edit mode * Remove double site editor redirect * Blocks: Migrate attribute filter E2E tests to playwright * Add changefile(s) from automation for the following project(s): woocommerce-blocks * Revert "Use canvas param instead of manually entering edit mode" This reverts commit 5e6cc17. * Revert "Remove double site editor redirect" This reverts commit 69a57a8. * Fix flaky products sorting test * Blocks: Fix ESLint errors (#46595) fix eslint error * update path * Fix ESLint errors (#46626) * Fix ESLint errors * Add changefile(s) from automation for the following project(s): woocommerce-blocks --------- Co-authored-by: github-actions <github-actions@github.com> * address feedback * fix visitSiteEditor * fix description * remove not necessary changelog --------- Co-authored-by: Bart Kalisz <bartlomiej.kalisz@gmail.com> Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: github-actions <github-actions@github.com>
rodelgc
added
status: analysis complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR is blocked by #46125
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR migrates the Rating Filter tests to the Playwright infrastructure.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment
Migrate Attribute filter tests to Playwright