New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: update REST API v3 reports/orders/totals endpoint to be compatible with HPOS #46715
Conversation
Hi @jorgeatorres, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
4d7bbf7
to
97fd247
Compare
Just for completeness, some instructions to test outside of the test suite:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Works as described. Thank you @lsinger!
97fd247
to
3810071
Compare
3810071
to
1fd92d3
Compare
…le with HPOS (#46715) * add a failing test for order totals with HPOS enabled but sync disabled * fix comment * ensure the wc/v3/reports/orders/totals endpoint is compatible with HPOS * add changelog file * address linter issues
…le with HPOS (#46715) * add a failing test for order totals with HPOS enabled but sync disabled * fix comment * ensure the wc/v3/reports/orders/totals endpoint is compatible with HPOS * add changelog file * address linter issues
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR updates the REST API v3 reports/orders/totals endpoint to be compatible with HPOS.
Closes woocommerce/woocommerce-ios#12468.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
pnpm test:php:env --filter=WC_Tests_API_Reports_Orders_Totals
pnpm test:php:env --filter=WC_Tests_API_Reports_Orders_Totals
Changelog entry
Significance
Type
Message
Comment