Block Hooks: Revert opening up hooked blocks to all block themes #46935
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
nerrad
added
team: Kirigami & Origami
block: mini-cart
danielwrobert
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
LGTM!
The code looks good.
I've tested against two themes outside of the $theme_include_list (Portia and Alara) and the hooked blocks are no longer inserted with this PR applied.
I've also tested against all of the themes in the $theme_include_list and the hooked blocks are inserted, as expected.
Based on this, I am approving the PR.
That being said, I noticed that in Amulet and Tazza, the positioning of the inserted blocks is a bit wonky (see screenshots below). This appears to mainly concern the My Account block, as opposed to the Mini-Cart so it seems best to create an issue and address that separately. But I wanted to note here, as I discovered it in testing for this PR.
Amulet:
Tazza:
github-actions
bot
added
the
needs: analysis
danielwrobert
added a commit
that referenced
this pull request
Apr 26, 2024
) * Revert opening up hooked blocks to all block themes. * Add changefile(s) from automation for the following project(s): woocommerce * Add version to @SInCE tag in fn comment. Missing @SInCE version throwing a CI check error: `A "@SInCE" tag was found but no version declared.` Adding `8.4.0`, as this was the version referenced before the revert. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com>
rodelgc
added a commit
that referenced
this pull request
Apr 27, 2024
…se (#46983) * Block Hooks: Revert opening up hooked blocks to all block themes (#46935) * Revert opening up hooked blocks to all block themes. * Add changefile(s) from automation for the following project(s): woocommerce * Add version to @SInCE tag in fn comment. Missing @SInCE version throwing a CI check error: `A "@SInCE" tag was found but no version declared.` Adding `8.4.0`, as this was the version referenced before the revert. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com> * Transfer changelog entry to readme.txt --------- Co-authored-by: Darren Ethier <darren@roughsmootheng.in> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Rodel Calasagsag <od.rodel.calasagsag@gmail.com>
samueljseay
pushed a commit
that referenced
this pull request
Apr 29, 2024
) * Revert opening up hooked blocks to all block themes. * Add changefile(s) from automation for the following project(s): woocommerce * Add version to @SInCE tag in fn comment. Missing @SInCE version throwing a CI check error: `A "@SInCE" tag was found but no version declared.` Adding `8.4.0`, as this was the version referenced before the revert. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com>
rodelgc
added
needs: external testing
github-actions bot
pushed a commit
that referenced
this pull request
May 1, 2024
) * Revert opening up hooked blocks to all block themes. * Add changefile(s) from automation for the following project(s): woocommerce * Add version to @SInCE tag in fn comment. Missing @SInCE version throwing a CI check error: `A "@SInCE" tag was found but no version declared.` Adding `8.4.0`, as this was the version referenced before the revert. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com>
This was referenced May 1, 2024
nigeljamesstevenson
pushed a commit
that referenced
this pull request
May 1, 2024
* Block Hooks: Revert opening up hooked blocks to all block themes (#46935) * Revert opening up hooked blocks to all block themes. * Add changefile(s) from automation for the following project(s): woocommerce * Add version to @SInCE tag in fn comment. Missing @SInCE version throwing a CI check error: `A "@SInCE" tag was found but no version declared.` Adding `8.4.0`, as this was the version referenced before the revert. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com> * Prep for cherry pick 46935 --------- Co-authored-by: Darren Ethier <darren@roughsmootheng.in> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Daniel W. Robert <danielwrobert@gmail.com> Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
In #45581, the WooCommerce implementation of the WP Block Hooks API auto-injects the mini-cart and customer account block on all sites with a block theme (running WooCommerce of course). After the release of WC 8.8 (where this change was introduced), we've discovered that impact on existing sites is greater than expected and are reverting until we can implement this more safely.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
The only themes this should apply to now are: "Twenty Twenty-Four, Twenty Twenty-Three, Twenty Twenty-Two, Tsubaki, Zaino, Thriving Artist, Amulet, Tazza" which were where the hooks were implemented as of WC 8.7.
Changelog entry
Significance
Type
Message
Reverts auto-injecting specific Woo Blocks in every block theme and restores only auto-injecting in themes found in the allow list.
Comment