Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone number to my account shipping address. #47062

Merged
merged 15 commits into from May 13, 2024

Conversation

wavvves
Copy link
Contributor

@wavvves wavvves commented Apr 30, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds the phone field to Shipping Address edit form under My Account, on par with the phone field presented on Billing Address form.
image

Closes #45717

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Edit the Checkout page, and within the Block click the Address section. On the sidebar enable the phone number field:
image
  1. On a logged-in WC installation, go to My Account > Addresses > Shipping Address edit
  2. Verify that the Phone field is display, and saving a phone number persists
  3. Verify that under My Account > Addresses Billing Address edit the Phone field also exists and saving a phone number persists
  4. Verify that it is possible to add different phone numbers to each of the address types
  5. Create an order and supply different phone numbers for each address
  6. Log in as admin, and open the order under WooCommerce > Orders
  7. Verify on the order details that the submitted phone numbers are correctly displayed

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Added phone number field to Shipping Address form under My Account

Comment

@wavvves wavvves self-assigned this Apr 30, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 30, 2024
@wavvves wavvves added the type: enhancement The issue is a request for an enhancement. label Apr 30, 2024
@wavvves wavvves marked this pull request as ready for review April 30, 2024 17:10
@woocommercebot woocommercebot requested review from a team and nielslange and removed request for a team April 30, 2024 17:10
Copy link
Contributor

github-actions bot commented Apr 30, 2024

Hi @senadir,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Hi @nielslange,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @wavvves. I'm preapproving it, but before merging it, let's make sure all CI checks are passing.

@wavvves wavvves marked this pull request as draft May 1, 2024 14:37
@wavvves wavvves marked this pull request as ready for review May 1, 2024 14:37
@woocommercebot woocommercebot requested review from a team and senadir and removed request for a team May 1, 2024 14:38
Copy link
Member

@senadir senadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the focus: e2e tests Issues related to e2e tests label May 7, 2024
Copy link
Contributor

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@wavvves wavvves merged commit 4840af8 into trunk May 13, 2024
23 checks passed
@wavvves wavvves deleted the add/phone-number-to-my-account-shipping-address branch May 13, 2024 11:48
@github-actions github-actions bot added this to the 9.0.0 milestone May 13, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 13, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 14, 2024
@senadir senadir added the team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add phone number to My Account -> Addresses -> Edit Shipping Address form
4 participants