Add some unit tests to cover changes in PR 46972

[jorgeatorres]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

In #46972 we fixed an issue with HPOS searches and terms including possibly url-encoded characters. This PR adds some unit tests to cover those changes.
It's basically a failing test for the prior behavior.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

From within the plugins/woocommerce directory:

1. Run the new tests and make sure they pass:
   vendor/bin/phpunit --filter=test_query_s_argument
   or (if using wpenv)
   pnpm test:php:env --filter=test_query_s_argument
2. (Optional) Confirm the tests don't pass in 8.8.3 (which has the bug):

   git co 8.8.3
   git co tests/test-46972 -- tests/php/src/Internal/DataStores/Orders/OrdersTableQueryTests.php
   vendor/bin/phpunit --filter=test_query_s_argument
   

   If you do this, reset the local changes by running git reset --hard.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Hi @vedanshujain,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Hi @vedanshujain,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions