Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue https://github.com/woocommerce/woocommerce/issues/28774 #47217

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

79mplus-admin
Copy link
Contributor

Trimming the password before updating

Changes proposed in this Pull Request:

Closes #28774

How to test the changes in this Pull Request:

  1. Go to "my-account/edit-account/".
  2. Change to a new password, including leading spaces.
  3. Now log in again with the new password.
  4. Attempt to change the password again, entering the old password with the leading spaces.
  5. The password will be changed successfully. Previously, it used to give the error message "Your current password is incorrect."

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels May 7, 2024
@woocommercebot woocommercebot requested review from a team and naman03malhotra and removed request for a team May 7, 2024 13:16
Copy link
Contributor

github-actions bot commented May 7, 2024

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with space password
1 participant