-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LYS - Update toolbar store link text #47315
LYS - Update toolbar store link text #47315
Conversation
Hi @psealock, @rjchow, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing well, code looks good 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and tested well. 🚢
f9d500e
to
31c3166
Compare
"Preview store" when coming soon mode is enabled "View store" when the site is set to live
e025b20
to
2a63104
Compare
* Update toolbar store link "Preview store" when coming soon mode is enabled "View store" when the site is set to live * Add changefile(s) from automation for the following project(s): woocommerce * Fix broken test --------- Co-authored-by: github-actions <github-actions@github.com>
"Preview store" when coming soon mode is enabled
"View store" when the site is set to live
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #47308
This pull updates the toolbar's store link based on the site's visibility settings.
It now displays "Preview store" when coming soon mode is active and "View store" when the site is live.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
WooCommerce -> Settings -> Site Visibility
and change the setting toLive
WooCommerce -> Home
View store
Coming soon
Preview store
Changelog entry
Significance
Type
Message
Updated the toolbar's store link based on the site's visibility settings.
Comment