Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LYS - Update toolbar store link text #47315

Merged

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented May 9, 2024

"Preview store" when coming soon mode is enabled
"View store" when the site is set to live

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #47308

This pull updates the toolbar's store link based on the site's visibility settings.

It now displays "Preview store" when coming soon mode is active and "View store" when the site is live.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new JN site with this branch.
  2. Go to WooCommerce -> Settings -> Site Visibility and change the setting to Live
  3. Go to WooCommerce -> Home
  4. Confirm the toolbar link says View store
  5. Change the setting to Coming soon
  6. Confirm the toolbar link says Preview store

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Updated the toolbar's store link based on the site's visibility settings.

Comment

@moon0326 moon0326 requested review from a team, psealock and rjchow May 9, 2024 11:32
Copy link
Contributor

github-actions bot commented May 9, 2024

Hi @psealock, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented May 9, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@moon0326 moon0326 closed this May 9, 2024
@moon0326 moon0326 reopened this May 9, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 9, 2024
Copy link
Contributor

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing well, code looks good 🚀

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and tested well. 🚢

@github-actions github-actions bot added focus: api tests Issues related to API tests. focus: e2e tests Issues related to e2e tests plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin. tool: monorepo infrastructure labels May 10, 2024
@moon0326 moon0326 force-pushed the update/47308-toolbar-should-say-view-store-when-site-is-live branch from f9d500e to 31c3166 Compare May 10, 2024 10:16
moon0326 and others added 3 commits May 10, 2024 03:16
"Preview store" when coming soon mode is enabled
"View store" when the site is set to live
@moon0326 moon0326 force-pushed the update/47308-toolbar-should-say-view-store-when-site-is-live branch from e025b20 to 2a63104 Compare May 10, 2024 10:17
@github-actions github-actions bot removed focus: api tests Issues related to API tests. plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin. tool: monorepo infrastructure focus: e2e tests Issues related to e2e tests labels May 10, 2024
@moon0326 moon0326 merged commit 0873ed4 into trunk May 10, 2024
24 checks passed
@moon0326 moon0326 deleted the update/47308-toolbar-should-say-view-store-when-site-is-live branch May 10, 2024 11:00
@github-actions github-actions bot added this to the 9.0.0 milestone May 10, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 10, 2024
senadir pushed a commit that referenced this pull request May 10, 2024
* Update toolbar store link

"Preview store" when coming soon mode is enabled
"View store" when the site is set to live

* Add changefile(s) from automation for the following project(s): woocommerce

* Fix broken test

---------

Co-authored-by: github-actions <github-actions@github.com>
@Stojdza Stojdza added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 10, 2024
@Stojdza Stojdza added the status: analysis complete Indicates if a PR has been analysed by Solaris label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar should say "View Store" when site is live
4 participants