Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for WCCOM connect flow #47842

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

thilinah
Copy link
Contributor

@thilinah thilinah commented May 27, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Start your development environment. pnpm -- wp-env start
  2. Make sure site is not connected.
  3. Site should be able to connect to WCCOM successfully.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Increase connection timeout to 30 seconds for the requests in WCCOM connection flow

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 27, 2024
Copy link
Contributor

github-actions bot commented May 27, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@thilinah thilinah self-assigned this May 27, 2024
@thilinah thilinah marked this pull request as ready for review May 27, 2024 14:18
@thilinah thilinah requested a review from nirolph May 27, 2024 14:18
Copy link
Contributor

Hi @nirolph,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@denho denho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thilinah
Copy link
Contributor Author

Close and open the PR to rerun checks

@thilinah thilinah closed this Jun 14, 2024
@thilinah thilinah reopened this Jun 14, 2024
@coreymckrill coreymckrill merged commit eabc599 into trunk Jun 17, 2024
37 checks passed
@coreymckrill coreymckrill deleted the update/increase-timeout-for-connect-flow branch June 17, 2024 18:53
@github-actions github-actions bot added this to the 9.1.0 milestone Jun 17, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jun 17, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants