-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYS: Ensure that toolbar appears only when the homepage sidebar is open #48115
CYS: Ensure that toolbar appears only when the homepage sidebar is open #48115
Conversation
Hi @samueljseay, @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Size Change: +573 B (+0.02%) Total Size: 2.47 MB |
…bar-is-rendered-only-when-the-homepage-sidebar-is-open' of github.com:woocommerce/woocommerce into 47751-cys-full-composability-ensure-that-the-block-toolbar-is-rendered-only-when-the-homepage-sidebar-is-open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, working great!
…en (#48115) * CYS: Ensure that toolbar appears only when the homepage sidebar is open * Add changefile(s) from automation for the following project(s): woocommerce * CYS: Ensure that toolbar appears only when the homepage sidebar is open * use usequery hook instead of navigation API --------- Co-authored-by: github-actions <github-actions@github.com>
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #47751.
This PR ensures that the toolbar appears only when the homepage sidebar is open.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
pattern-toolkit-full-composability
on the list.Changelog entry
Significance
Type
Message
CYS: Ensure that toolbar appears only when the homepage sidebar is open
Comment