Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYS: Ensure that toolbar appears only when the homepage sidebar is open #48115

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Jun 3, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #47751.

This PR ensures that the toolbar appears only when the homepage sidebar is open.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure that you have the last version of Gutenberg enabled
  2. Make sure you have the WooCommerce beta tester plugin installed
  3. Head over to Tools > WCA Test Helper > Features
  4. Make sure you see the pattern-toolkit-full-composability on the list.
  5. Enable it.
  6. Head over to WooCommerce > Home > Customize your store.
  7. Click on blocks.
  8. Ensure that no block toolbar appears
  9. On the sidebar, click on "Design your homepage"
  10. Ensure that the Block Toolbar appears.

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS: Ensure that toolbar appears only when the homepage sidebar is open

Comment

@woocommercebot woocommercebot requested review from a team and samueljseay and removed request for a team June 3, 2024 15:54
@gigitux gigitux requested review from nefeline and albarin June 3, 2024 15:54
@gigitux gigitux self-assigned this Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Hi @samueljseay, @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@gigitux gigitux added type: enhancement The issue is a request for an enhancement. team: Kirigami & Origami WC Store Editing (FSE) focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Size Change: +573 B (+0.02%)

Total Size: 2.47 MB

compressed-size-action

…bar-is-rendered-only-when-the-homepage-sidebar-is-open' of github.com:woocommerce/woocommerce into 47751-cys-full-composability-ensure-that-the-block-toolbar-is-rendered-only-when-the-homepage-sidebar-is-open
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 3, 2024
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, working great!

@gigitux gigitux merged commit 2698eab into trunk Jun 4, 2024
27 checks passed
@gigitux gigitux deleted the 47751-cys-full-composability-ensure-that-the-block-toolbar-is-rendered-only-when-the-homepage-sidebar-is-open branch June 4, 2024 12:11
@github-actions github-actions bot added this to the 9.1.0 milestone Jun 4, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jun 4, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jun 5, 2024
thealexandrelara pushed a commit that referenced this pull request Jul 18, 2024
…en (#48115)

* CYS: Ensure that toolbar appears only when the homepage sidebar is open

* Add changefile(s) from automation for the following project(s): woocommerce

* CYS: Ensure that toolbar appears only when the homepage sidebar is open

* use usequery hook instead of navigation API

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami WC Store Editing (FSE) type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS - Full Composability]: Ensure that the block toolbar is rendered only when the homepage sidebar is open
3 participants