-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document template parts used by the Classic Template block #48183
Document template parts used by the Classic Template block #48183
Conversation
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Hi @WunderBart, @imanish003, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Aljullu,
Thanks for improving the documentation of the Classic Template block. I've reviewed the changes and they look good to me. I've left a few minor suggestions. I am pre-approving this PR so you can merge it once the suggestions are addressed 🚀
plugins/woocommerce-blocks/assets/js/blocks/classic-template/README.md
Outdated
Show resolved
Hide resolved
plugins/woocommerce-blocks/docs/internal-developers/templates/README.md
Outdated
Show resolved
Hide resolved
plugins/woocommerce-blocks/docs/internal-developers/templates/classic-template.md
Outdated
Show resolved
Hide resolved
…README.md Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com>
…classic-template.md Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com>
Changes proposed in this Pull Request:
This PR updates the documentation of the Classic Template block so:
Closes #47219.
How to test the changes in this Pull Request:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment