Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Optimise shipping calculations flow when using the Checkout block #48449

Open
wants to merge 5 commits into
base: update/46949-cart-block-with-shipping-calculations-enabled
Choose a base branch
from

Conversation

tarunvijwani
Copy link
Contributor

@tarunvijwani tarunvijwani commented Jun 12, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

We're optimizing shipping calculations flow when using the Checkout block. With this PR, we're making the following changes:

  • We are changing the wording No shipping options available in the order summary section to Enter the address to calculate, and displaying it in 80% of the font size of the Shipping label and normal, neither <strong> nor <em> when no address is provided.
  • We are changing the wording Shipping options will be displayed here after entering your full shipping address to Enter a shipping address to view shipping options with the text vertically and horizontally centered and a grey background when no address is provided.
  • We are changing the wording Add a shipping address to view shipping options to Enter a shipping address to view shipping options with the text vertically and horizontally centered and a grey background when a partial address is provided.
  • When a full address is provided, but no shipping options are available for that address, we're changing the wording There are no shipping options available. Please check your shipping address. to No shipping options are available for this address. Please verify the address is correct or try a different address..
  • When a full address is provided, but no shipping options are available for that address, we're changing the wording No shipping options available in the order summary section to No available delivery option, and displaying it in 80% of the font size of the Shipping label and normal, neither <strong> nor <em>.

Closes #46951.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  • Go to /wp-admin/admin.php?page=wc-settings&tab=shipping&section=options.
  • Enable the option Enable the shipping calculator on the cart page.
  • Go to /wp-admin/admin.php?page=wc-settings&tab=shipping&section=pickup_location
  • Disable local pickup.
  • Go to /wp-admin/admin.php?page=wc-settings&tab=shipping&section.
  • Remove all shipping methods.
  • Add one shipping method to one country only (Example: UAE).
  • Open an incognito window.
  • Add a product to the cart.
  • Go to the Checkout page that is using the Checkout block.
  1. Confirm the text in the order summary section is Enter the address to calculate.
Before After
image image
  1. Confirm the text in the shipping rate selector is Enter a shipping address to view shipping options vertically and horizontally centered and with a grey background.
Before After
image image
  1. Enter the partial shipping address and confirm the text in the shipping rate selector is Enter a shipping address to view shipping options vertically and horizontally centered and with a grey background.
Before After
image image
  1. Enter the full shipping address for the other country where no shipping method is available (Example: US).
  2. Confirm the text in the order summary section is No available delivery option.
Before After
image image
  1. Confirm there is a notice in the shipping rate selector, and the text of the notice is No shipping options are available for this address. Please verify the address is correct or try a different address..
Before After
image image

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Optimise shipping calculations flow when using the Checkout block

Changelog Entry Comment

Comment

- Change wordings in order summary for Checkout block.
- Change wordings for shipping rate control message when address is incomplete or not present.
- Change wordings for shipping rate control notice when address is complete
@tarunvijwani tarunvijwani self-assigned this Jun 12, 2024
@tarunvijwani tarunvijwani added type: enhancement The issue is a request for an enhancement. focus: cart Issues related to the cart. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues focus: checkout Issues related to checkout page. and removed focus: cart Issues related to the cart. labels Jun 12, 2024
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Size Change: +582 B (+0.02%)

Total Size: 2.49 MB

compressed-size-action

Tarun Vijwani and others added 3 commits June 13, 2024 00:06
@tarunvijwani tarunvijwani marked this pull request as ready for review June 12, 2024 21:52
@woocommercebot woocommercebot requested review from a team and nielslange and removed request for a team June 12, 2024 21:52
Copy link
Contributor

Hi @nielslange,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@nielslange nielslange closed this Jun 13, 2024
@nielslange nielslange reopened this Jun 13, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 13, 2024
…led' into update/46951-checkout-block-shipping-calculations-flow
Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @tarunvijwani. I've successfully tested this PR and the code looks good. Let's ⛴️ this improvement.

@tarunvijwani
Copy link
Contributor Author

Quick update: I'm holding the merge until #47953 is merged into the featured branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout Issues related to checkout page. plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants