-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Optimise shipping calculations flow when using the Checkout block #48449
base: update/46949-cart-block-with-shipping-calculations-enabled
Are you sure you want to change the base?
Conversation
- Change wordings in order summary for Checkout block. - Change wordings for shipping rate control message when address is incomplete or not present. - Change wordings for shipping rate control notice when address is complete
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Size Change: +582 B (+0.02%) Total Size: 2.49 MB |
…led' into update/46951-checkout-block-shipping-calculations-flow
Hi @nielslange, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
…led' into update/46951-checkout-block-shipping-calculations-flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @tarunvijwani. I've successfully tested this PR and the code looks good. Let's ⛴️ this improvement.
Quick update: I'm holding the merge until #47953 is merged into the featured branch. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
We're optimizing shipping calculations flow when using the Checkout block. With this PR, we're making the following changes:
No shipping options available
in the order summary section toEnter the address to calculate
, and displaying it in 80% of the font size of theShipping
label and normal, neither<strong>
nor<em>
when no address is provided.Shipping options will be displayed here after entering your full shipping address
toEnter a shipping address to view shipping options
with the text vertically and horizontally centered and a grey background when no address is provided.Add a shipping address to view shipping options
toEnter a shipping address to view shipping options
with the text vertically and horizontally centered and a grey background when a partial address is provided.There are no shipping options available. Please check your shipping address.
toNo shipping options are available for this address. Please verify the address is correct or try a different address.
.No shipping options available
in the order summary section toNo available delivery option
, and displaying it in 80% of the font size of theShipping
label and normal, neither<strong>
nor<em>
.Closes #46951.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/admin.php?page=wc-settings&tab=shipping§ion=options
.Enable the shipping calculator on the cart page
./wp-admin/admin.php?page=wc-settings&tab=shipping§ion=pickup_location
/wp-admin/admin.php?page=wc-settings&tab=shipping§ion
.Enter the address to calculate
.Enter a shipping address to view shipping options
vertically and horizontally centered and with a grey background.Enter a shipping address to view shipping options
vertically and horizontally centered and with a grey background.No available delivery option
.No shipping options are available for this address. Please verify the address is correct or try a different address.
.Changelog entry
Changelog Entry Details
Significance
Type
Message
Optimise shipping calculations flow when using the Checkout block
Changelog Entry Comment
Comment