Don't recommend WCS&T in tax task if WCShip or WCTax is active

[waclawjacek]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Part of woocommerce/woocommerce-shipping#187.

If the "WooCommerce Shipping" or "WooCommerce Tax" extension is active, don't recommend the incompatible "WooCommerce Shipping & Tax" extension.

This PR implements the above restriction in the WC > Home > task list > Collect sales tax task.

Screenshots

Before:

(Note the screenshot recommends "WooCommerce Tax" but the solution used under the hood is actually the "WooCommerce Shipping & Tax" extension.)

After, if WCShip or WCTax is present:

(The "Configure" button leads to the WC > Settings > Tax > Standard rates page.)

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Build WC from this PR and install it on a fresh site.
2. Skip the onboarding and set the store location to US California.
3. Go to WC > Home and try going through the Collect sales tax task with WCShip/WCTax enabled and disabled. WCS&T should only be recommended when neither of WCShip/WCTax is active.

Changelog entry

• Automatically create a changelog entry from the details below.

• This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

If either the upcoming WooCommerce Shipping or WooCommerce Tax extension is active, don't suggest WooCommerce Shipping & Tax in the "Collect sales tax" Home task.

This only adjusts the extension recommendation merchants receive and does not affect any other functionality.

[github-actions]

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

[github-actions]

Size Change: 0 B

Total Size: 2.49 MB

_{compressed-size-action}

[github-actions]

Hi @Ferdev,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[Ferdev]

Code looks good 👍
I built WooCommerce (this branch), latest WooCommerce Shipping and latest WooCommerce Tax and installed them on a new site. With WooCommerce Shipping and WooCommerce Tax disabled, the collect tax task shows "WooCommerce Tax" in the first step of the wizard. If any of them are enabled, or both, the "WooCommerce Tax" extension is not recommended anymore.
So yeah, this is ready to ship Thanks!