Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYS - Fix register testimonials category as reviews failing test #48719

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Jun 21, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Fixes a failing unit tests.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Make sure all tests in CI are passing.

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Fix the "test_fetch_patterns_should_register_testimonials_category_as_reviews" tests.

Changelog Entry Comment

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 21, 2024
@albarin albarin marked this pull request as ready for review June 21, 2024 11:38
@albarin albarin closed this Jun 21, 2024
@albarin albarin reopened this Jun 21, 2024
@albarin albarin requested a review from gigitux June 21, 2024 11:38
Copy link
Contributor

Hi @gigitux,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! 🚀

@albarin albarin merged commit 4976011 into trunk Jun 21, 2024
25 checks passed
@albarin albarin deleted the fix-ptk-unit-test branch June 21, 2024 11:55
@github-actions github-actions bot added this to the 9.2.0 milestone Jun 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jun 21, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants