Drop Select2 in Backwards compatable manner

[naman03malhotra]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes #48577

Given that Select2 and SelectWoo have the same APIs, this PR points the registry of the Select2 library to SelectWoo.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Please test it with the following instructions:

• Open \wp-admin > advanced > Webhooks page
• In wc-enchanced-select.js replace .selectWoo with .select2 every where in the file.
• Refresh and clear browser cache if required.
• Verify if the file is loaded with select2 by going to browser console > sources > cmd + p > search for wc-enhanced-select.js > verify if it has select2.
• Select Dropdown should work as expected in \wp-admin > advanced > Webhooks page

Changelog entry

• Automatically create a changelog entry from the details below.

• This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

[github-actions]

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

[github-actions]

Size Change: 0 B

Total Size: 2.5 MB

_{compressed-size-action}

[github-actions]

Hi @jorgeatorres, @frosso, @coreymckrill, @claudiulodro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[naman03malhotra]

Requested @jorgeatorres's review, and he already has some context on it.

[jorgeatorres]

Overall, this looks good to me @naman03malhotra. Thanks for working on this!

In the admin, we're still registering a select2 script, which we could also point to selectWoo. It should be safer to even remove it entirely, but I guess there might be extensions out there relying on this for whatever reason.

woocommerce/plugins/woocommerce/includes/admin/class-wc-admin-assets.php

Line 152 in 55aafb9

wp_register_script( 'select2', WC()->plugin_url() . '/assets/js/select2/select2.full' . $suffix . '.js', array( 'jquery' ), '4.0.3' );

[naman03malhotra]

In the admin, we're still registering a select2 script, which we could also point to selectWoo. It should be safer to even remove it entirely, but I guess there might be extensions out there relying on this for whatever reason.

Good catch @jorgeatorres, I've made the change, also I've kept the version same to avoid duplicate downloads with different hashes.

It should be safer to even remove it entirely, but I guess there might be extensions out there relying on this for whatever reason.

Yep, maybe we can plan a depreciation path for this, but it is safe to have this namespace exposed.