WCA Test helper - add remote inbox notification staging importer #48735

moon0326 · 2024-06-21T22:41:28Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

This PR adds a new tool to the WCA Test Helper that helps import remote inbox notifications from staging or production for testing purposes. Since this tool cover functionalities from Admin notes tool, I've retired it.

Import from staging requires Automattic proxy connected.

Import remote inbox notifications from https://staging.woocommerce.com or https://woocommerce.com
Delete all
Delete a single notification
Notification tester

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Checkout this branch locally.
cd to plugins/woocommerce-beta-tester and run pnpm run build:zip
Create a new JN site with the latest WooCommerce
Upload and activate woocommerce-beta-tester.zip
Go to Tools -> WCA Test Helper -> Remote Inbox Notifications
Click on Import from staging
Confirm it throws an error.
Connect to Automattic Proxy.
Click on Import from staging again.
Confirm it works and notifications from https://staging.woocommerce.com/wp-json/wccom/inbox-notifications/1.0/notifications.json have been imported.

Changelog entry

Automatically create a changelog entry from the details below.

This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Adds a new tool to the WCA Test Helper that helps import remote inbox notifications from staging or production for testing purposes

Changelog Entry Comment

Comment

github-actions · 2024-06-21T22:47:14Z

Hi @ilyasfoo, @chihsuan,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

github-actions · 2024-06-21T22:47:14Z

Hi @ilyasfoo, @chihsuan,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

…mmerce-beta-tester

github-actions · 2024-06-21T22:47:55Z

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

github-actions · 2024-06-21T22:52:13Z

Size Change: +31 B (0%)

Total Size: 2.49 MB

_{compressed-size-action}

…mmerce-beta-tester, woocommerce

…ox Notifications

chihsuan

I encountered an error when trying to delete all notes.

Screen.Recording.2024-06-24.at.16.43.46.mov

Other than that, tested well and the tool is working as expected.

chihsuan · 2024-06-24T08:50:14Z

plugins/woocommerce-beta-tester/src/remote-inbox-notifications/index.js

+	setNotice,
+} ) {
+	const importFromEnv = async ( env ) => {
+		const urls = {


It would be helpful if we could also allow users to use a custom URL for the import. This way, we can test some functionalities unavailable in staging or production and fetch notes from a gist URL to test PR changes. What do you think?

Added in 7e628ac

I encountered an error when trying to delete all notes.

It seems like JN does not like DELETE methods. I've changed DELETE to POST. Please try again.

ilyasfoo

I think this is a much better solution compared to the previous one, great work
@moon0326!

I have a few comments, but everything is testing well except for the delete all similar to @chihsuan.

I'm curious if difference between button placement is different than in the PR description, is it intended? (screenshot)

...a-tester/api/remote-inbox-notifications/class-wca-test-helper-remote-inbox-notifications.php

plugins/woocommerce-beta-tester/src/remote-inbox-notifications/data/actions.js

plugins/woocommerce/src/Admin/RemoteSpecs/RuleProcessors/RuleEvaluator.php

…/class-wca-test-helper-remote-inbox-notifications.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

…valuator.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

…/class-wca-test-helper-remote-inbox-notifications.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

…mmerce-beta-tester

…ix DELETE method errors

chihsuan

Nice work, tested well. 👍

…mote-notification-importer Fix filename typo

…mmerce-beta-tester

Fix changelog filename typo

…mmerce-beta-tester

It seems the new CI is automatically creating a changelog based on branch name 43d6abe

ilyasfoo

Awesome, thanks for adding the public function as utilities! Tests well, LGTM! 🚢

moon0326 added 3 commits June 21, 2024 12:38

Add Remote inbox notifications management

40a2b2d

Remove admin notes section -- replaced by remote inbox notifications

61faa86

Add import from staging and production

f398df0

github-actions bot added the plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin. label Jun 21, 2024

moon0326 requested review from ilyasfoo and chihsuan June 21, 2024 22:46

moon0326 marked this pull request as ready for review June 21, 2024 22:47

Add changefile(s) from automation for the following project(s): wooco…

ea4e4ca

…mmerce-beta-tester

moon0326 added 3 commits June 21, 2024 19:19

WIP - change test to run

71580a6

Display failed rules on error

edf833a

Change run to test

c08a236

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 22, 2024

Add changefile(s) from automation for the following project(s): wooco…

5eed617

…mmerce-beta-tester, woocommerce

moon0326 marked this pull request as draft June 22, 2024 02:33

moon0326 added 6 commits June 21, 2024 20:06

Retire Remote Spec Ruel Validation -- use test action from Remote Inb…

06f6361

…ox Notifications

Run spec when all rules have passed

f3f76ab

Fix typo

c9d9786

Change btn text to Run

a43ee3d

Update copy text

5c674d7

Place delete all button on the left side

e346d06

moon0326 marked this pull request as ready for review June 23, 2024 00:44

chihsuan reviewed Jun 24, 2024

View reviewed changes

ilyasfoo requested changes Jun 24, 2024

View reviewed changes

moon0326 and others added 2 commits June 24, 2024 12:15

Update plugins/woocommerce-beta-tester/api/remote-inbox-notifications…

97ff8b4

…/class-wca-test-helper-remote-inbox-notifications.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

Update plugins/woocommerce/src/Admin/RemoteSpecs/RuleProcessors/RuleE…

22dafc8

…valuator.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

moon0326 and others added 3 commits June 24, 2024 12:15

Update plugins/woocommerce-beta-tester/api/remote-inbox-notifications…

a0399e6

…/class-wca-test-helper-remote-inbox-notifications.php Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

Add changefile(s) from automation for the following project(s): wooco…

016983c

…mmerce-beta-tester

Separate remote inbox notification heler functions into a class and f…

587d6fa

…ix DELETE method errors

github-actions bot removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 24, 2024

moon0326 added 6 commits June 24, 2024 15:02

Fix typo

7ea7d31

Display all errors

d47969f

Fix errors

e8881c4

Fix error with test

8c362bf

Add import from URL

7e628ac

Change func name to importFromUrl

4679722

chihsuan approved these changes Jun 25, 2024

View reviewed changes

ilyasfoo and others added 5 commits June 25, 2024 11:12

Rename 48735-feature-remote-notiifcation-importer to 48735-feature-re…

20f0e30

…mote-notification-importer Fix filename typo

Add changefile(s) from automation for the following project(s): wooco…

43e926d

…mmerce-beta-tester

Fix changelog filename typo

c0ccf65

Fix changelog filename typo

Add changefile(s) from automation for the following project(s): wooco…

43d6abe

…mmerce-beta-tester

Revert adding new changelog

39d0a42

It seems the new CI is automatically creating a changelog based on branch name 43d6abe

ilyasfoo approved these changes Jun 25, 2024

View reviewed changes

moon0326 merged commit a09522d into trunk Jun 25, 2024
13 checks passed

moon0326 deleted the feature/remote-notiifcation-importer branch June 25, 2024 06:32

moon0326 mentioned this pull request Jun 26, 2024

Beta tester - fix lint errors #48825

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WCA Test helper - add remote inbox notification staging importer #48735

WCA Test helper - add remote inbox notification staging importer #48735

moon0326 commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024

github-actions bot commented Jun 21, 2024

github-actions bot commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

chihsuan left a comment

chihsuan Jun 24, 2024

moon0326 Jun 24, 2024

moon0326 Jun 24, 2024 •

edited

Loading

moon0326 Jun 24, 2024

ilyasfoo left a comment

chihsuan left a comment

ilyasfoo left a comment

WCA Test helper - add remote inbox notification staging importer #48735

WCA Test helper - add remote inbox notification staging importer #48735

Conversation

moon0326 commented Jun 21, 2024 • edited Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

github-actions bot commented Jun 21, 2024

github-actions bot commented Jun 21, 2024

github-actions bot commented Jun 21, 2024 • edited Loading

Test using WordPress Playground

github-actions bot commented Jun 21, 2024 • edited Loading

chihsuan left a comment

Choose a reason for hiding this comment

chihsuan Jun 24, 2024

Choose a reason for hiding this comment

moon0326 Jun 24, 2024

Choose a reason for hiding this comment

moon0326 Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

moon0326 Jun 24, 2024

Choose a reason for hiding this comment

ilyasfoo left a comment

Choose a reason for hiding this comment

chihsuan left a comment

Choose a reason for hiding this comment

ilyasfoo left a comment

Choose a reason for hiding this comment

moon0326 commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

moon0326 Jun 24, 2024 •

edited

Loading